Convert libvirt template to workflow #12825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobbymoodge
reviewed
Oct 14, 2020
ci-operator/step-registry/openshift/e2e/libvirt/test/openshift-e2e-libvirt-test-commands.sh
Outdated
Show resolved
Hide resolved
sallyom
force-pushed
the
praveen-libvirt-workflow
branch
6 times, most recently
from
ea60e09 to
a7dd46b
Compare
tnozicka
reviewed
Oct 15, 2020
...or/step-registry/openshift/e2e/gcp/libvirt/setup/openshift-e2e-gcp-libvirt-setup-commands.sh
Outdated
Show resolved
Hide resolved
...or/step-registry/openshift/e2e/gcp/libvirt/setup/openshift-e2e-gcp-libvirt-setup-commands.sh
Outdated
Show resolved
Hide resolved
...or/step-registry/openshift/e2e/gcp/libvirt/setup/openshift-e2e-gcp-libvirt-setup-commands.sh
Outdated
Show resolved
Hide resolved
...ator/step-registry/openshift/e2e/gcp/libvirt/test/openshift-e2e-gcp-libvirt-test-commands.sh
Outdated
Show resolved
Hide resolved
sallyom
force-pushed
the
praveen-libvirt-workflow
branch
13 times, most recently
from
af2574b to
f5154ce
Compare
Contributor
Author
|
@praveenkumar it's ready!! I added the same set of tests that are currently running in the openshift/installer libvirt-e2e job. |
This was referenced Oct 17, 2020
Contributor
Author
|
@praveenkumar , after this merges, we can look at replacing the custom image with a provision script within the |
Contributor
|
/lgtm |
Contributor
|
/assign @abhinavdahiya |
wking
reviewed
Oct 20, 2020
ci-operator/step-registry/openshift/e2e/gcp/libvirt/conf/OWNERS
Outdated
Show resolved
Hide resolved
wking
reviewed
Oct 20, 2020
...ator/step-registry/openshift/e2e/gcp/libvirt/conf/openshift-e2e-gcp-libvirt-conf-commands.sh
Outdated
Show resolved
Hide resolved
- move libvirt workflow under openshift/e2e/gcp - add ServerAlive vars to ssh config - configure list of e2es to run - extract openshift-tests
sallyom
force-pushed
the
praveen-libvirt-workflow
branch
from
f5154ce to
b002981
Compare
Contributor
Author
|
thanks for the review @wking, updated, ptal! |
Contributor
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, praveenkumar, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@sallyom: Updated the following 5 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up @praveenkumar 's PR to rebase/test/add ssh config vars