Skip to content

Update libvirt template, extract installer from RELEASE_IMAGE_LATEST #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sallyom wants to merge 2 commits into from
Closed

Update libvirt template, extract installer from RELEASE_IMAGE_LATEST #9969

sallyom wants to merge 2 commits into from

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Jun 29, 2020 •
edited
Loading

This PR depends on openshift/installer#3812 and will require some coordination.

  • I have an extra commit in this PR to test using the files baked into the libvirt-installer image before that PR merges.
    Once that PR merges, I'll remove the extra commit here and test provision-host.sh and create-cluster obtained from the new libvirt-installer image.
  • Once these 2 PRs merge, I'll open a follow-up to remove the libvirt installer binary build from the libvirt-installer image, as this is not required when we extract the binary from the release image.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2020
@sallyom
Copy link
Contributor Author

sallyom commented Jun 29, 2020 •
edited
Loading

/hold

until openshift/installer#3812 merges, and I remove the extra test commit here.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020
@sallyom sallyom mentioned this pull request Jun 29, 2020
Closed
@sallyom sallyom force-pushed the update-libvirt-e2e-template branch 2 times, most recently from ef9616e to dd515ae Compare June 29, 2020 13:42
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 29, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To complete the pull request process, please assign adduarte
You can assign the PR to them by writing /assign @adduarte in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sallyom sallyom force-pushed the update-libvirt-e2e-template branch 4 times, most recently from c9d764e to 15ddbd1 Compare June 29, 2020 15:22
@sallyom sallyom force-pushed the update-libvirt-e2e-template branch from 15ddbd1 to 2028825 Compare June 29, 2020 15:39
@sallyom sallyom changed the title WIP: Update libvirt template, extract installer from RELEASE_IMAGE_LATEST Update libvirt template, extract installer from RELEASE_IMAGE_LATEST Jun 29, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2020
@sallyom
Copy link
Contributor Author

sallyom commented Jun 30, 2020

/retest

@sallyom sallyom force-pushed the update-libvirt-e2e-template branch from 2028825 to a3e72ce Compare July 1, 2020 17:31
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

@sallyom: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-api-provider-libvirt/master/e2e-libvirt a3e72ce link /test pj-rehearse
ci/prow/pj-rehearse a3e72ce link /test pj-rehearse
ci/prow/ci-testgrid-allow-list a3e72ce link /test ci-testgrid-allow-list
ci/prow/yamllint a3e72ce link /test yamllint
ci/prow/boskos-config a3e72ce link /test boskos-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom
Copy link
Contributor Author

sallyom commented Oct 19, 2020

moving to step-registry workflow, closing in favor of #12825

@sallyom sallyom closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sallyom @openshift-ci-robot