ci-operator/step-registry: Dedup OWNERS with symlinks #9739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step-registry CI currently requires each directory to contain an OWNERS file (ci/prow/owners). Often, those OWNERS sets are the same as the parent-directory's OWNERS file. To ease maintenance, we can use symlinks to ../OWNERS to explicitly say "this is the same set", as we started to do in 0f27f00 (ci-operator/step-registry/openshift: Push e2e flavors under e2e/, 2020-06-10, openshift#9612). This commit adds a script to automate that deduping, and also commits the state generated by: $ hack/dedup-owners.sh ci-operator/step-registry
Member
Author
|
/assign @hongkailiu All green, and Blunderbuss suggested you :). |
hongkailiu
approved these changes
Jun 18, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@wking: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Jun 24, 2020
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 14, 2020
Like 0a90079 (ci-operator/step-registry: Dedup OWNERS with symlinks, 2020-06-17, openshift#9739), picking up all the dups that have crept in since then. Generated with: $ hack/dedup-owners.sh ci-operator/step-registry
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jan 25, 2022
Like 0a90079 (ci-operator/step-registry: Dedup OWNERS with symlinks, 2020-06-17, openshift#9739), picking up all the dups that have crept in since the most recent round, possibly e168265 (assisted-installer: Dedup OWNERS files using hack/dedup-owners.sh, 2021-07-06, openshift#19931). Generated with: $ hack/dedup-owners.sh ci-operator/step-registry
This was referenced Jan 25, 2022
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Apr 29, 2022
Like 0a90079 (ci-operator/step-registry: Dedup OWNERS with symlinks, 2020-06-17, openshift#9739) and 9c1d14a (ci-operator/step-registry: Dedup OWNERS with symlinks again, 2022-01-24, openshift#25574), picking up all the dups that have crept in since the most recent round, possibly 9c1d14a. Generated with: $ hack/dedup-owners.sh ci-operator/step-registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step-registry CI currently requires each directory to contain an
OWNERSfile (ci/prow/owners). Often, thoseOWNERSsets are the same as the parent-directory'sOWNERSfile. To ease maintenance, we can use symlinks to../OWNERSto explicitly say "this is the same set", as we started to do in 0f27f00 (#9612). This commit adds a script to automate that deduping, and also commits the state generated by:$ hack/dedup-owners.sh ci-operator/step-registry