Skip to content

moving proxy setup from UPI to multi-step #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 8, 2020
Merged

moving proxy setup from UPI to multi-step #9904

openshift-merge-robot merged 1 commit into from
Jul 8, 2020

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Jun 24, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 24, 2020
@wking
Copy link
Member

wking commented Jun 24, 2020

When you get around to adding OWNERS to address this failure, it might help to define a single OWNERS for the proxy support (with you and me and... anyone else?) in one core-ish directory and make the other OWNERS symlinks to that directory. See #9739 pushing OWNERS symlinks.

@ewolinetz ewolinetz force-pushed the multi-step-proxy branch 7 times, most recently from 7b0e950 to 4a84891 Compare June 25, 2020 17:12
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jun 25, 2020

/test pj-rehearse

@wking
Copy link
Member

wking commented Jun 26, 2020

Build image baremetal-installer from the repository.

/retest

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jun 26, 2020

/test pj-rehearse

@ewolinetz ewolinetz force-pushed the multi-step-proxy branch 2 times, most recently from 82d0644 to 7801cc4 Compare June 26, 2020 17:02
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jun 26, 2020

/test pj-rehearse

3 similar comments
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jun 26, 2020

/test pj-rehearse

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jun 26, 2020

/test pj-rehearse

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jun 26, 2020

/test pj-rehearse

@ewolinetz ewolinetz force-pushed the multi-step-proxy branch 2 times, most recently from d1cda35 to 2dcfa2e Compare June 26, 2020 23:11
@ewolinetz ewolinetz force-pushed the multi-step-proxy branch 3 times, most recently from f351c2c to 394a04e Compare June 29, 2020 18:56
wking
wking reviewed Jul 6, 2020
View reviewed changes
@ewolinetz ewolinetz force-pushed the multi-step-proxy branch 2 times, most recently from 1cff0f3 to dc8a825 Compare July 6, 2020 20:36
wking
wking reviewed Jul 6, 2020
View reviewed changes
@ewolinetz ewolinetz force-pushed the multi-step-proxy branch 3 times, most recently from 5d78a6c to 300ef57 Compare July 6, 2020 21:45
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 6, 2020

/test pj-rehearse

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 7, 2020

/retest

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 7, 2020

/test pj-rehearse

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 7, 2020

/retest

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 7, 2020

/refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2020 •
edited
Loading

@ewolinetz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-kube-apiserver-operator/master/e2e-aws-serial 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-aws-image-registry 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/builder/master/e2e-aws-builds 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-windows-hybrid-network 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-aws-sdn-multi 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-aws 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift-knative/serverless-operator/master/4.3-upgrade-tests-aws-ocp-43 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-ovn-hybrid-step-registry 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/builder/master/e2e-aws-image-ecosystem 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/openshift/kubernetes/marun-testing13/kubernetes-e2e 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse
ci/rehearse/cri-o/cri-o/master/e2e-aws 300ef576dda1fa5fecea3b612630f40615b074bd link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wking
wking reviewed Jul 8, 2020
View reviewed changes
@wking
Copy link
Member

wking commented Jul 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 31f6e88 into openshift:master Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2020

@ewolinetz: Updated the following 5 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/gather/proxy/OWNERS
    • key gather-proxy-commands.sh using file ci-operator/step-registry/gather/proxy/gather-proxy-commands.sh
    • key gather-proxy-ref.yaml using file ci-operator/step-registry/gather/proxy/gather-proxy-ref.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/aws/post/proxy/OWNERS
    • key ipi-aws-post-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/post/proxy/ipi-aws-post-proxy-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/aws/pre/proxy/OWNERS
    • key ipi-aws-pre-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/pre/proxy/ipi-aws-pre-proxy-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/conf/aws/proxy/OWNERS
    • key ipi-conf-aws-proxy-chain.yaml using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-chain.yaml
    • key ipi-conf-aws-proxy-commands.sh using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-commands.sh
    • key ipi-conf-aws-proxy-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/aws/proxy/OWNERS
    • key openshift-e2e-aws-proxy-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/proxy/openshift-e2e-aws-proxy-workflow.yaml
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/gather/proxy/OWNERS
    • key gather-proxy-commands.sh using file ci-operator/step-registry/gather/proxy/gather-proxy-commands.sh
    • key gather-proxy-ref.yaml using file ci-operator/step-registry/gather/proxy/gather-proxy-ref.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/aws/post/proxy/OWNERS
    • key ipi-aws-post-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/post/proxy/ipi-aws-post-proxy-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/aws/pre/proxy/OWNERS
    • key ipi-aws-pre-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/pre/proxy/ipi-aws-pre-proxy-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/conf/aws/proxy/OWNERS
    • key ipi-conf-aws-proxy-chain.yaml using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-chain.yaml
    • key ipi-conf-aws-proxy-commands.sh using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-commands.sh
    • key ipi-conf-aws-proxy-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/aws/proxy/OWNERS
    • key openshift-e2e-aws-proxy-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/proxy/openshift-e2e-aws-proxy-workflow.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ewolinetz @wking @openshift-ci-robot @openshift-merge-robot