OADP-1833: Cleanup completed VSBs in backup finalize phase#268
OADP-1833: Cleanup completed VSBs in backup finalize phase#268shubham-pampattiwar wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@shubham-pampattiwar: This pull request references OADP-1833 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
|
Then you have to update controllergen in the ci dockerfile or however that's run. |
|
@shubham-pampattiwar: This pull request references OADP-1833 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
added
the
needs-rebase
|
@shubham-pampattiwar: This pull request references OADP-1833 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
shubham-pampattiwar
removed
the
needs-rebase
|
I have one concern here -- this involves CRD changes, so we will no longer be able to say that our Velero CRDs are identical to upstream. I don't know whether any of these differences will introduce incopatibilities or not, though. |
|
Attempting to revert controller-gen changes. |
|
This is the error in question. kubernetes-sigs/controller-tools#613 |
|
Fix is in kubernetes-sigs/controller-tools@32ad710 which appears first in v0.9.0. |
|
This seems to work. Need a bit more work See Tests in #270 |
|
@shubham-pampattiwar: This pull request references OADP-1833 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@shubham-pampattiwar gotta merge this yourself whenever you're ready.. no OWNERS file = no auto merge. |
|
Lets target this at oadp-1.2 directly (since we need to pull in some poentially-conflicting changes into konveyor-dev from upstream main, and then we may not need the overrides), and we can put this on konveyor-dev separately once that's done. Otherwise, LGTM. |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
sseago
left a comment
sseago
left a comment
There was a problem hiding this comment.
LGTM, but re-target at oadp-1.2 before merging.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eemcmullan, kaovilai, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fix unit test revert to using controller-gen 0.7 update vsb failed check condition
shubham-pampattiwar
force-pushed
the
del-vsb-final
branch
from
9a13ecf to
abd4ed0
Compare
|
New changes are detected. LGTM label has been removed. |
|
As discussed here is the PR for oadp-1.2: #271 |
|
@shubham-pampattiwar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this one, since oadp-1.2 one was merged and this will need rework before moving to konveyor-dev (post-next-rebase) |
6 participants
veleroImageFqin: 'quay.io/spampatt/velero:del-vsb-final-take-2'