Skip to content

OADP-1833: Cleanup completed VSBs in backup finalize phase#271

Merged
shubham-pampattiwar merged 1 commit into
openshift:oadp-1.2from
shubham-pampattiwar:del-vsb-final-cp
May 18, 2023
Merged

OADP-1833: Cleanup completed VSBs in backup finalize phase#271
shubham-pampattiwar merged 1 commit into
openshift:oadp-1.2from
shubham-pampattiwar:del-vsb-final-cp

Conversation

@shubham-pampattiwar
Copy link
Copy Markdown
Member

No description provided.

fix unit test

revert to using controller-gen 0.7

update vsb failed check condition

(cherry picked from commit abd4ed0)
@shubham-pampattiwar shubham-pampattiwar self-assigned this May 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 17, 2023

@shubham-pampattiwar: This pull request references OADP-1833 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2023

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar shubham-pampattiwar merged commit 34ab2a0 into openshift:oadp-1.2 May 18, 2023
@kaovilai kaovilai mentioned this pull request Jul 11, 2023
3 tasks
sseago pushed a commit that referenced this pull request Aug 10, 2023
fix unit test

revert to using controller-gen 0.7

update vsb failed check condition

(cherry picked from commit abd4ed0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants