Skip to content

Conversation

@xingxingxia
Copy link
Contributor

For #89 (comment)
Local test passed:
For:

  Scenario: Test oc version
    When I run the :version client command
    Then the step should succeed
    And evaluation of `@result[:props][:oc_version]` is stored in the :oc_version clipboard
    And evaluation of `@result[:props][:kubernetes_server_version]` is stored in the :k8s_s_version clipboard
    And I pry

Got:

    Then the step should succeed
    And evaluation of `@result[:props][:oc_version]` is stored in the :oc_version clipboard
    And evaluation of `@result[:props][:kubernetes_server_version]` is stored in the :k8s_s_version clipboard                                                  
[1] pry(#<BushSlicer::DefaultWorld>)> cb.oc_version
=> "4.0.17"
[2] pry(#<BushSlicer::DefaultWorld>)> cb.k8s_s_version
=> "1.12.4+b3e6ad4"

@akostadinov pls help check/merge, thanks!

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 7, 2019
@xingxingxia
Copy link
Contributor Author

I copy from 3.x yaml, only changed rule for oc version.
@xiaocwan @yapei fyi, now your case OCP-19678 Check general info on console will pass:

    When I run the :version client command
    Then the step should succeed

@pruan-rht
Copy link
Member

LGTM

@yapei
Copy link
Contributor

yapei commented Mar 8, 2019

@xingxingxia Thank you for the fix

Copy link
Member

@pruan-rht pruan-rht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pruan-rht, xingxingxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9318789 into openshift:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants