Skip to content

Conversation

@xingxingxia
Copy link
Contributor

@xingxingxia xingxingxia commented Feb 26, 2019

Recent openshift/origin#21434 is merged
This makes auto fail:
https://openshift-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Runner-v3/38503/console

   Given I have a project
      [02:43:06] INFO> Shell Commands: rm  -f -- /home/jenkins/workspace/Runner-v3/workdir/cucushift-oc40-standard-slave-cn7gk-0/ocp4_zhouy2.kubeconfig
      [02:43:06] INFO> Exit Status: 0
      [02:43:06] INFO> Shell Commands: oc version --config=/tmp/kubeconfig20190226-370-182k0n1
      Client Version: version.Info{Major:"4", Minor:"0+", GitVersion:"v4.0.0-0.183.0", GitCommit:"99fca4beb8", GitTreeState:"", BuildDate:"2019-02-23T23:55:36Z", GoVersion:"", Compiler:"", Platform:""}
      
      [02:43:06] INFO> Exit Status: 0
      undefined method `[]' for nil:NilClass (NoMethodError)
      /home/jenkins/workspace/Runner-v3/lib/cli_executor.rb:68:in `get_version_for'
      /home/jenkins/workspace/Runner-v3/lib/cli_executor.rb:259:in `version'
      /home/jenkins/workspace/Runner-v3/lib/cli_executor.rb:249:in `executor'
      /home/jenkins/workspace/Runner-v3/lib/cli_executor.rb:289:in `user_opts'
      /home/jenkins/workspace/Runner-v3/lib/cli_executor.rb:299:in `exec'
      /home/jenkins/workspace/Runner-v3/lib/api_accessor.rb:71:in `cli_exec'
      /home/jenkins/workspace/Runner-v3/lib/api_accessor_owner.rb:28:in `public_send'
      /home/jenkins/workspace/Runner-v3/lib/api_accessor_owner.rb:28:in `block (2 levels) in <module:APIAccessorOwner>'
      /home/jenkins/workspace/Runner-v3/lib/openshift/cluster_resource.rb:162:in `get_matching'
      /home/jenkins/workspace/Runner-v3/lib/openshift/user.rb:143:in `projects'
      /home/jenkins/workspace/Runner-v3/lib/openshift/user.rb:113:in `block in clean_projects'
      /home/jenkins/workspace/Runner-v3/lib/base_helper.rb:153:in `wait_for'
      /home/jenkins/workspace/Runner-v3/lib/openshift/user.rb:112:in `clean_projects'
      /home/jenkins/workspace/Runner-v3/lib/openshift/user.rb:138:in `clean_up_on_load'
      /home/jenkins/workspace/Runner-v3/lib/user_manager.rb:107:in `[]'
      /home/jenkins/workspace/Runner-v3/lib/world.rb:147:in `user'
      /home/jenkins/workspace/Runner-v3/features/step_definitions/project.rb:21:in `/^I have a project$/'
      features/cli/deploy.feature:35:in `Given I have a project'

Local test passed when using xingxingxia@fe21160
@akostadinov @pruan-rht pls check/merge, thx

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2019
@pruan-rht pruan-rht removed the request for review from cjryan February 26, 2019 04:00
@pruan-rht
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pruan-rht, xingxingxia
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cjryan

If they are not already assigned, you can assign the PR to them by writing /assign @cjryan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pruan-rht
Copy link
Member

I'll merge...Thanks!

@pruan-rht pruan-rht merged commit a3d6c52 into openshift:master Feb 26, 2019
@akostadinov
Copy link
Contributor

This should also be fixed in lib/rules/cli/4.0.yaml

@xingxingxia
Copy link
Contributor Author

Good catch. Will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants