WINC-805: Add support for Windows Server 2022 in AWS by jrvaldes · Pull Request #1091 · openshift/windows-machine-config-operator

jrvaldes · 2022-06-06T13:55:44Z

This PR updates the AWS's EC2 AMI to use Windows Server 2022
Base image without Docker container runtime, as the container runtime
(containerd) is installed by WMCO.

Leverage the environment variable introduced in the release job configuration to use Windows Server 2019 as machine and container images for the aws-e2e-operator test

WINC-805: Use Windows Server 2019 in aws-e2e-operator test release#29791

openshift-ci · 2022-06-06T13:55:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

mansikulkarni96 · 2022-06-06T15:12:03Z

/test azure-e2e-operator

jrvaldes · 2022-06-07T13:59:44Z

/test aws-e2e-operator

jrvaldes · 2022-06-07T14:00:05Z

/test lint

mansikulkarni96 · 2022-06-07T14:25:04Z

/test aws-e2e-upgrade

saifshaikh48

Code changes lgtm, question on docs

selansen · 2022-06-07T18:13:21Z

Can you pls add a few lines in the description section?

mansikulkarni96 · 2022-06-07T19:41:42Z

Don't we need to update the image deployed for networking test here

jrvaldes · 2022-06-07T21:27:51Z

Don't we need to update the image deployed for networking test here

Yes, addressed in 8abf347

jrvaldes · 2022-06-08T19:24:20Z

/test aws-e2e-operator

jrvaldes · 2022-06-08T20:36:34Z

/test aws-e2e-operator

jrvaldes · 2022-06-09T14:53:59Z

/test aws-e2e-operator

jrvaldes · 2022-06-09T22:19:18Z

/test aws-e2e-operator

jrvaldes · 2022-06-13T18:57:56Z

/test aws-e2e-operator

jrvaldes · 2022-06-13T18:59:53Z

/test aws-e2e-upgrade

jrvaldes · 2022-06-14T14:44:51Z

/test aws-e2e-upgrade

jrvaldes · 2022-06-14T15:01:55Z

/test aws-e2e-operator

Build src image failed

jrvaldes · 2022-08-04T19:10:13Z

/test aws-e2e-operator

jrvaldes · 2022-08-05T13:28:59Z

/test aws-e2e-ccm-install

jrvaldes · 2022-08-11T06:40:13Z

/test aws-e2e-upgrade

jrvaldes · 2022-08-11T07:28:22Z

/test aws-e2e-upgrade

jrvaldes · 2022-08-11T18:09:40Z

Rebased with:

Update AWS machineset docs #1172

sebsoto · 2022-08-15T19:22:47Z

-		patchData, meta.PatchOptions{})
-	if err != nil {
-		return errors.Wrapf(err, "error removing version annotation from node %s", nc.node.GetName())
+	// Check version annotation and remove iff present


How does this commit relate to adding Server 2022 support?

jrvaldes · 2022-08-17T17:06:08Z

/hold

To investigate the issue with AWS EC2 metadata endpoint not available.

AWS EC2 instance metadata endpoint not available for kubelet after hybrid-overlay is running on Windows Server 2022 ovn-kubernetes/ovn-kubernetes#3119

This commit declares support for Windows Server 2022 in the documentation.

This commit updates the hack/machineset.sh script to use Windows Server 2022 base image without containers for AWS machineSets. In addition, re-arrange the aws cli command that fetch the AMI id with a multiline for better readability.

This commit updates the AWS's EC2 AMI to use Windows Server 2022 base image without container runtime. The container runtime (containerd) is installed by WMCO. It also leverages the environment variable introduced in openshift/release#29791 to allow a parameter-based configuration for Windows Server version, where the machine and container images can be adjusted in the e2e test suite. In addition, adjusts the logic for PowerShell cmdlets to avoid escaping the double-quotes when default shell is PowerShell to taking into account the Windows Server version.

jrvaldes · 2022-11-10T06:11:50Z

/test aws-e2e-upgrade

jrvaldes · 2022-11-10T06:12:20Z

/test aws-e2e-operator

openshift-ci · 2022-11-10T06:13:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please assign aravindhp for approval by writing /assign @aravindhp in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This change introduces a hack to circumvent the routing issue in Windows Server 2022 running the EC2Launch V2 agent where the instance metadata endpoint is not available after hybrid-overlay is running as a Windows service. See ovn-kubernetes/ovn-kubernetes#3119

jrvaldes · 2022-11-10T14:48:40Z

/test aws-e2e-upgrade

jrvaldes · 2022-11-10T14:48:47Z

/test aws-e2e-operator

openshift-ci · 2022-11-10T18:46:57Z

@jrvaldes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/vsphere-e2e-operator	`c312195`	link	true	`/test vsphere-e2e-operator`
ci/prow/gcp-e2e-operator	`c312195`	link	true	`/test gcp-e2e-operator`
ci/prow/platform-none-vsphere-e2e-operator	`c312195`	link	true	`/test platform-none-vsphere-e2e-operator`
ci/prow/aws-e2e-upgrade	`c77dc9d`	link	true	`/test aws-e2e-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aravindhp · 2023-02-04T00:08:02Z

/close

This hack does not work. For one EC2Launch v2 is a service and we should be restarting that and not just executing the binary. Further more restarting the service does not result in the routes being recreated as the services loops waiting for an IP address:

2023-02-03 00:33:31 Console: Network interface configuration is empty...waiting for an IP...
2023-02-03 00:34:35 Console: Network interface configuration is empty...waiting for an IP...

openshift-merge-robot · 2023-02-04T00:08:10Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-04T00:08:13Z

@aravindhp: Closed this PR.

Details

In response to this:

/close

This hack does not work. For one EC2Launch v2 is a service and we should be restarting that and not just executing the binary. Further more restarting the service does not result in the routes being recreated as the services loops waiting for an IP address:
2023-02-03 00:33:31 Console: Network interface configuration is empty...waiting for an IP...
2023-02-03 00:34:35 Console: Network interface configuration is empty...waiting for an IP...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022

openshift-ci Bot requested review from mansikulkarni96 and selansen June 6, 2022 13:56

jrvaldes force-pushed the WINC-805 branch from 431a72f to 3546f64 Compare June 6, 2022 14:04

jrvaldes force-pushed the WINC-805 branch from 3546f64 to 69c8e1d Compare June 7, 2022 13:56

jrvaldes mentioned this pull request Jun 7, 2022

[e2e] CustomVXLANPort no longer relevant in AWS #1094

Closed

saifshaikh48 reviewed Jun 7, 2022

View reviewed changes

Comment thread docs/machineset-aws.md Outdated

Comment thread docs/machineset-aws.md Outdated

jrvaldes force-pushed the WINC-805 branch 2 times, most recently from 8abf347 to 7193a6d Compare June 7, 2022 21:52

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022

jrvaldes force-pushed the WINC-805 branch from eb7792e to 7708b5a Compare June 9, 2022 22:18

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022

jrvaldes force-pushed the WINC-805 branch 2 times, most recently from 1968bfd to 004f74b Compare June 13, 2022 16:13

jrvaldes force-pushed the WINC-805 branch from fbdffe4 to 120f5d3 Compare August 11, 2022 07:27

jrvaldes marked this pull request as ready for review August 11, 2022 07:46

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2022

openshift-ci Bot requested review from aravindhp and removed request for selansen August 11, 2022 07:51

jrvaldes force-pushed the WINC-805 branch from 120f5d3 to efd47c2 Compare August 11, 2022 18:09

jrvaldes force-pushed the WINC-805 branch 3 times, most recently from 92c0a91 to 64f5930 Compare August 13, 2022 20:20

sebsoto reviewed Aug 15, 2022

View reviewed changes

jrvaldes mentioned this pull request Aug 17, 2022

AWS EC2 instance metadata endpoint not available for kubelet after hybrid-overlay is running on Windows Server 2022 ovn-kubernetes/ovn-kubernetes#3119

Closed

jrvaldes added 3 commits November 10, 2022 01:07

[docs] Add support for WS2022 in AWS

3b8b583

This commit declares support for Windows Server 2022 in the documentation.

[hack] Use WS2022 in machineset.sh for AWS

11af55d

This commit updates the hack/machineset.sh script to use Windows Server 2022 base image without containers for AWS machineSets. In addition, re-arrange the aws cli command that fetch the AMI id with a multiline for better readability.

Conversation

jrvaldes commented Jun 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 6, 2022

Uh oh!

mansikulkarni96 commented Jun 6, 2022

Uh oh!

jrvaldes commented Jun 7, 2022

Uh oh!

jrvaldes commented Jun 7, 2022

Uh oh!

mansikulkarni96 commented Jun 7, 2022

Uh oh!

saifshaikh48 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

selansen commented Jun 7, 2022

Uh oh!

mansikulkarni96 commented Jun 7, 2022

Uh oh!

jrvaldes commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrvaldes commented Jun 8, 2022

Uh oh!

jrvaldes commented Jun 8, 2022

Uh oh!

jrvaldes commented Jun 9, 2022

Uh oh!

jrvaldes commented Jun 9, 2022

Uh oh!

jrvaldes commented Jun 13, 2022

Uh oh!

jrvaldes commented Jun 13, 2022

Uh oh!

jrvaldes commented Jun 14, 2022

Uh oh!

jrvaldes commented Jun 14, 2022

Uh oh!

jrvaldes commented Aug 4, 2022

Uh oh!

jrvaldes commented Aug 5, 2022

Uh oh!

jrvaldes commented Aug 11, 2022

Uh oh!

jrvaldes commented Aug 11, 2022

Uh oh!

jrvaldes commented Aug 11, 2022

Uh oh!

sebsoto Aug 15, 2022

Choose a reason for hiding this comment

Uh oh!

jrvaldes Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jrvaldes commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrvaldes commented Nov 10, 2022

Uh oh!

jrvaldes commented Nov 10, 2022

Uh oh!

openshift-ci Bot commented Nov 10, 2022

Uh oh!

jrvaldes commented Nov 10, 2022

Uh oh!

jrvaldes commented Nov 10, 2022

Uh oh!

openshift-ci Bot commented Nov 10, 2022

Uh oh!

aravindhp commented Feb 4, 2023

Uh oh!

openshift-merge-robot commented Feb 4, 2023

Uh oh!

openshift-ci Bot commented Feb 4, 2023

Uh oh!

jrvaldes commented Jun 6, 2022 •

edited

Loading

jrvaldes commented Jun 7, 2022 •

edited

Loading

jrvaldes commented Aug 17, 2022 •

edited

Loading