Skip to content

[e2e] CustomVXLANPort no longer relevant in AWS#1094

Closed
jrvaldes wants to merge 1 commit into
openshift:masterfrom
jrvaldes:remove-CustomVXLANPort-check-in-aws
Closed

[e2e] CustomVXLANPort no longer relevant in AWS#1094
jrvaldes wants to merge 1 commit into
openshift:masterfrom
jrvaldes:remove-CustomVXLANPort-check-in-aws

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented Jun 7, 2022

This PR removes the hasCustomVXLANPort parameter from the
AWS provider initialization. The CustomVXLANPort is no longer a valid
decision element to choose between Windows Server 2022 or 2019 in AWS,
because there is no corresponding CI job definition for a cluster with
a HybridOverlay network and a CustomVXLANPort in AWS.

This commit removes the hasCustomVXLANPort parameter from the
AWS provider initialization. The CustomVXLANPort is no longer a valid
decision element to choose between Windows Server 2022 or 2019 in AWS,
because there is no corresponding CI job definition for a cluster with
a HybridOverlay network and a CustomVXLANPort in AWS.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Jun 7, 2022

/test lint

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Jun 7, 2022

/test ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

@jrvaldes: The following commands are available to trigger required jobs:

  • /test aws-e2e-ccm-install
  • /test aws-e2e-operator
  • /test aws-e2e-upgrade
  • /test azure-e2e-operator
  • /test build
  • /test ci-index
  • /test images
  • /test lint
  • /test platform-none-vsphere-e2e-operator
  • /test unit
  • /test vsphere-e2e-operator
  • /test wicd-unit-vsphere

The following commands are available to trigger optional jobs:

  • /test azure-e2e-ccm-install

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-ccm-install
  • pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-upgrade
  • pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-build
  • pull-ci-openshift-windows-machine-config-operator-master-ci-index
  • pull-ci-openshift-windows-machine-config-operator-master-images
  • pull-ci-openshift-windows-machine-config-operator-master-lint
  • pull-ci-openshift-windows-machine-config-operator-master-platform-none-vsphere-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-unit
  • pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-wicd-unit-vsphere
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from mansikulkarni96 and sebsoto June 7, 2022 03:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
To complete the pull request process, please assign selansen after the PR has been reviewed.
You can assign the PR to them by writing /assign @selansen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Jun 7, 2022

/test aws-e2e-operator

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Jun 7, 2022

/test aws-e2e-upgrade

@sebsoto
Copy link
Copy Markdown
Contributor

sebsoto commented Jun 7, 2022

changes LGTM

@jrvaldes jrvaldes marked this pull request as ready for review June 7, 2022 13:58
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Jun 7, 2022

/close

Included in #1091

@jrvaldes jrvaldes closed this Jun 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

@jrvaldes: Closed this PR.

Details

In response to this:

/close

Included in #1091

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

/reopen

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 22, 2022

@jrvaldes: Failed to re-open PR: state cannot be changed. The remove-CustomVXLANPort-check-in-aws branch was force-pushed or recreated.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants