Make log test more resilient#1214
Conversation
sebsoto
force-pushed
the
nodeLogsRetries
branch
from
ee21f68 to
715c1cf
Compare
|
/approve cancel |
openshift-ci
Bot
added
approved
sebsoto
force-pushed
the
nodeLogsRetries
branch
from
715c1cf to
245848c
Compare
|
/lgtm |
|
/lgtm |
|
/cherry-pick release-4.11 |
|
@sebsoto: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // Grab the optional logs for debugging purposes | ||
| for _, file := range optionalLogs { | ||
| _ = retrieveLog(node.Name, file, nodeDir) | ||
| _ = wait.PollImmediate(retry.Interval, retry.ResourceChangeTimeout, func() (bool, error) { |
There was a problem hiding this comment.
Why are we ignoring the error here?
There was a problem hiding this comment.
These logs are not guaranteed to be present. We still want to collect them if they exist
There was a problem hiding this comment.
Please add a comment stating this. Grab the optional logs for debugging purposes does not explain why we are not looking at the error.
openshift-ci
Bot
added
the
approved
|
/retest |
|
retest |
|
/retest |
| let retries+=1 | ||
| echo "failed to get WMCO logs" | ||
| sleep 5 |
There was a problem hiding this comment.
Is it possible to indent?
There was a problem hiding this comment.
I just replaced the tabs with spaces, didnt realize they were there.
This file is split between 4 and 2 spaces, but the majority of it is 2 space indenting, so chose 2 for this function.
| // Grab the optional logs for debugging purposes | ||
| for _, file := range optionalLogs { | ||
| _ = retrieveLog(node.Name, file, nodeDir) | ||
| _ = wait.PollImmediate(retry.Interval, retry.ResourceChangeTimeout, func() (bool, error) { |
There was a problem hiding this comment.
Please add a comment stating this. Grab the optional logs for debugging purposes does not explain why we are not looking at the error.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a retry for node log retrieval to guard against network related flakes, and logs the command output upon failure.
Retries the attempt but will not fail when collecting WMCO logs between different test suites.
sebsoto
force-pushed
the
nodeLogsRetries
branch
from
1fa05b1 to
85a10ae
Compare
|
/lgtm |
|
/retest |
|
/test azure-e2e-operator |
|
/retry |
|
/retest |
|
/retest-required |
|
@sebsoto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sebsoto: new pull request created: #1217 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.10 |
|
@mansikulkarni96: new pull request created: #1465 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@sebsoto: new pull request created: #1508 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Adds a retry for node log retrieval, and logs the command output upon
failure.