Skip to content

WINC-520: Inject oc cli in test images#26395

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jrvaldes:WINC-520-injecting-the-oc-cli
Aug 29, 2022
Merged

WINC-520: Inject oc cli in test images#26395
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jrvaldes:WINC-520-injecting-the-oc-cli

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented Feb 20, 2022 •
edited
Loading

This change leverage the release images to inject the oc cli according to the OCP version.

See https://docs.ci.openshift.org/docs/architecture/step-registry/#injecting-the-oc-cli

Ran:
make update

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 20, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Feb 20, 2022

/test pj-rehearse

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 27, 2022

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 27, 2022
@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Mar 30, 2022

/remove-lifecycle stale

@openshift-ci openshift-ci Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2022

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 17, 2022

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 17, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 1, 2022

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Aug 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2022

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Aug 25, 2022

/remove-lifecycle rotten

@openshift-ci openshift-ci Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 25, 2022
@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Aug 25, 2022

/reopen

@openshift-ci openshift-ci Bot reopened this Aug 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 25, 2022

@jrvaldes: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022
@jrvaldes jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch from 2de2274 to 912757b Compare August 25, 2022 21:14
@jrvaldes jrvaldes changed the title WIP: Inject oc cli in test image WINC-520: Inject oc cli in test images Aug 25, 2022
@jrvaldes jrvaldes marked this pull request as ready for review August 25, 2022 21:17
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022
@openshift-ci openshift-ci Bot requested a review from aravindhp August 25, 2022 21:18
aravindhp
aravindhp reviewed Aug 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrvaldes I suggest adding a temporary test step inline to check if this actually worked. This is from the doc you linked,

tests:
  - as: with-cli
    steps:
      test:
        - as: use-cli
          commands: oc adm policy add-role-to-user --help
          from: os    # use the "os" image for running the test
          cli: custom # allow the CLI from the "custom" release to be available
          resources:
            requests:
              cpu: 100m
              memory: 200Mi

jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Aug 25, 2022
@jrvaldes
[build] Stop downloading oc client
dcedbaf 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
@jrvaldes jrvaldes mentioned this pull request Aug 25, 2022
Merged
@sebsoto
Copy link
Copy Markdown
Contributor

sebsoto commented Aug 26, 2022

/hold
Please wait for openshift/windows-machine-config-operator#1214 to merge, merging this PR will cause the jobs to run again

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@jrvaldes jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch from 350f5af to a692d58 Compare August 26, 2022 17:10
@sebsoto
Copy link
Copy Markdown
Contributor

sebsoto commented Aug 26, 2022

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@sebsoto
Copy link
Copy Markdown
Contributor

sebsoto commented Aug 26, 2022

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, jrvaldes, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 26, 2022

@jrvaldes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/platform-none-vsphere-e2e-operator 2de2274d784f20fa43a65d26cc9b097d9698f8eb link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.7/aws-e2e-upgrade 350f5afdb03654361ca35978ad9ff05ba3e1df0c link unknown /test pj-rehearse
ci/prow/pj-rehearse a692d58 link false /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.13/aws-e2e-upgrade a692d58 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Aug 29, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 3f82126 into openshift:master Aug 29, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 29, 2022

@jrvaldes: Updated the following 7 configmaps:

  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.13.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.13.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.8.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.8.yaml
  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.9.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.9.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.10.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.10.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.11.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.11.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.12.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.12.yaml
Details

In response to this:

This change leverage the release images to inject the oc cli according to the OCP version.

See https://docs.ci.openshift.org/docs/architecture/step-registry/#injecting-the-oc-cli

Ran:
make update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Aug 29, 2022
@jrvaldes
[build] Stop downloading oc client
76589ca 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Aug 29, 2022
@jrvaldes
[build] Stop downloading oc client
af54921 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Aug 29, 2022
@jrvaldes
[build] Stop downloading oc client
abb8294 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Aug 29, 2022
@jrvaldes
[build] Stop downloading oc client
7288b5c 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Aug 29, 2022
@jrvaldes
[build] Stop downloading oc client
209eea5 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
@jrvaldes jrvaldes mentioned this pull request Aug 31, 2022
Closed
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Sep 7, 2022
@jrvaldes
[build] Stop downloading oc client
c1fa08c 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/windows-machine-config-operator-1 that referenced this pull request Sep 12, 2022
@jrvaldes
Stop downloading oc client
4242f50 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Sep 12, 2022
@jrvaldes
[build] Stop downloading oc client
e3b1418 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395

(cherry picked from commit c1fa08c)
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Sep 12, 2022
@jrvaldes
[build] Stop downloading oc client
5118465 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395

(cherry picked from commit c1fa08c)
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Sep 12, 2022
@jrvaldes
[build] Stop downloading oc client
baad9a1 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395

(cherry picked from commit c1fa08c)
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/windows-machine-config-operator-1 that referenced this pull request Sep 13, 2022
@jrvaldes
Stop downloading oc client
fbc5e2d 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395
@jrvaldes jrvaldes deleted the WINC-520-injecting-the-oc-cli branch April 2, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

1 more reviewer

@aravindhp aravindhp aravindhp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sebsoto sebsoto

@aravindhp aravindhp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jrvaldes @openshift-bot @aravindhp @sebsoto @openshift-merge-robot