WINC-520: Stop downloading oc client and leverage test image binaries by jrvaldes · Pull Request #1216 · openshift/windows-machine-config-operator

jrvaldes · 2022-08-25T21:38:52Z

This change leverages the introduction of the oc client in the test
images, making the build process simpler.

In addition, ensures the oc binary is present, prints the location
and the version.

openshift-ci · 2022-08-25T21:38:56Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jrvaldes · 2022-08-25T21:41:39Z

/hold

Depends on:

WINC-520: Inject oc cli in test images release#26395

saifshaikh48

/lgtm

jrvaldes · 2022-08-29T13:50:53Z

/hold cancel

WINC-520: Inject oc cli in test images release#26395 has merges

jrvaldes · 2022-08-29T13:51:18Z

/test ?

openshift-ci · 2022-08-29T13:51:21Z

@jrvaldes: The following commands are available to trigger required jobs:

/test aws-e2e-ccm-install
/test aws-e2e-operator
/test aws-e2e-upgrade
/test azure-e2e-operator
/test build
/test ci-index
/test images
/test lint
/test platform-none-vsphere-e2e-operator
/test unit
/test vsphere-e2e-operator
/test wicd-unit-vsphere

The following commands are available to trigger optional jobs:

/test azure-e2e-ccm-install
/test gcp-e2e-operator
/test vsphere-e2e-ccm-install

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-ccm-install
pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator
pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-upgrade
pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator
pull-ci-openshift-windows-machine-config-operator-master-build
pull-ci-openshift-windows-machine-config-operator-master-ci-index
pull-ci-openshift-windows-machine-config-operator-master-images
pull-ci-openshift-windows-machine-config-operator-master-lint
pull-ci-openshift-windows-machine-config-operator-master-platform-none-vsphere-e2e-operator
pull-ci-openshift-windows-machine-config-operator-master-unit
pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator
pull-ci-openshift-windows-machine-config-operator-master-wicd-unit-vsphere

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrvaldes · 2022-08-29T13:51:55Z

/test vsphere-e2e-operator

jrvaldes · 2022-08-29T13:52:07Z

/test images

jrvaldes · 2022-08-29T16:00:07Z

/test images

jrvaldes · 2022-08-29T16:31:07Z

Got a syntax error in the script and fixed it.

/test images

jrvaldes · 2022-08-29T18:36:08Z

/test vsphere-e2e-operator

jrvaldes · 2022-08-29T19:04:39Z

/test images

jrvaldes · 2022-08-29T19:15:05Z

/test vsphere-e2e-operator

openshift-ci-robot · 2022-08-31T23:10:43Z

/retest-required

Remaining retests: 0 against base HEAD 9db93ab and 2 for PR HEAD 7125803 in total

aravindhp · 2022-08-31T23:18:40Z

/hold

until WINC-879 is fixed

This change leverages the introduction of the oc client in the test images, making the build process simpler. Follow-up to openshift/release#26395

This change ensures the oc binary is present, or fails otherwise. In addition, prints the location and the version.

jrvaldes · 2022-09-07T01:05:27Z

/hold cancel

Blocker PR merged:

WINC-879: Introduce Pod Security admission labels #1230

jrvaldes · 2022-09-07T12:21:53Z

/retest-required

saifshaikh48

/lgtm

jrvaldes · 2022-09-07T13:06:33Z

/retest-required

vsphere-e2e-operator-ipi-install-monitoringpvc step failed with expected file at https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 to have checksum e70e482e7ddb9cf83b52f5e83b694a19e3aaf36acf6b82512cbe66e41d569201 but instead got 159f5c90ade00159d2d662cd55aaa3844f7dd3897005293a56a78207c57c993b

openshift-ci · 2022-09-07T15:03:26Z

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jrvaldes · 2022-09-07T15:13:14Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-09-07T15:13:55Z

@jrvaldes: #1216 failed to apply on top of branch "release-4.11":

Applying: Stop downloading oc client
Applying: Ensure oc cli is present for e2e tests
Using index info to reconstruct a base tree...
M	hack/run-ci-e2e-test.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/run-ci-e2e-test.sh
CONFLICT (content): Merge conflict in hack/run-ci-e2e-test.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Ensure oc cli is present for e2e tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrvaldes · 2022-09-12T13:40:25Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-09-12T13:41:07Z

@jrvaldes: new pull request created: #1243

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrvaldes · 2022-09-12T13:41:52Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-09-12T13:42:30Z

@jrvaldes: #1216 failed to apply on top of branch "release-4.10":

Applying: Stop downloading oc client
Applying: Ensure oc cli is present for e2e tests
Using index info to reconstruct a base tree...
M	hack/run-ci-e2e-test.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/run-ci-e2e-test.sh
CONFLICT (content): Merge conflict in hack/run-ci-e2e-test.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Ensure oc cli is present for e2e tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jrvaldes · 2022-09-13T16:55:08Z

/cherry-pick community-4.11

openshift-cherrypick-robot · 2022-09-13T16:55:47Z

@jrvaldes: new pull request created: #1249

Details

In response to this:

/cherry-pick community-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022

jrvaldes changed the title ~~[build] Stop downloading oc client~~ WINC-520: Stop downloading oc client and leverage test image binaries Aug 25, 2022

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2022

aravindhp mentioned this pull request Aug 25, 2022

WINC-520: Inject oc cli in test images openshift/release#26395

Merged

saifshaikh48 reviewed Aug 29, 2022

View reviewed changes

openshift-ci Bot assigned saifshaikh48 Aug 29, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2022

jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch from dcedbaf to 76589ca Compare August 29, 2022 15:49

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022

jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch 2 times, most recently from af54921 to abb8294 Compare August 29, 2022 15:59

jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch from abb8294 to 7288b5c Compare August 29, 2022 16:30

jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch from 7288b5c to 209eea5 Compare August 29, 2022 19:01

jrvaldes marked this pull request as ready for review August 29, 2022 22:01

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2022

openshift-ci Bot requested review from aravindhp and sebsoto August 29, 2022 22:02

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022

jrvaldes added 2 commits September 6, 2022 21:02

[build] Stop downloading oc client

c1fa08c

This change leverages the introduction of the oc client in the test images, making the build process simpler. Follow-up to openshift/release#26395

[hack] Ensure oc cli is present for e2e tests

bad87d2

This change ensures the oc binary is present, or fails otherwise. In addition, prints the location and the version.

jrvaldes force-pushed the WINC-520-injecting-the-oc-cli branch from 7125803 to bad87d2 Compare September 7, 2022 01:03

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022

saifshaikh48 reviewed Sep 7, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022

openshift-merge-robot merged commit 9484ad1 into openshift:master Sep 7, 2022

openshift-cherrypick-robot mentioned this pull request Sep 12, 2022

[release-4.11] WINC-520: Stop downloading oc client and leverage test image binaries #1243

Merged

aravindhp mentioned this pull request Sep 13, 2022

[build] Switch to golang 1.18 in Dockerfile.ci #1247

Merged

openshift-cherrypick-robot mentioned this pull request Sep 13, 2022

[community-4.11] WINC-520: Stop downloading oc client and leverage test image binaries #1249

Merged

jrvaldes deleted the WINC-520-injecting-the-oc-cli branch August 8, 2023 21:08

Conversation

jrvaldes commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Aug 25, 2022

Uh oh!

jrvaldes commented Aug 25, 2022

Uh oh!

saifshaikh48 left a comment

Choose a reason for hiding this comment

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

openshift-ci Bot commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

jrvaldes commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 31, 2022

Uh oh!

aravindhp commented Aug 31, 2022 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrvaldes commented Sep 7, 2022

Uh oh!

jrvaldes commented Sep 7, 2022

Uh oh!

saifshaikh48 left a comment

Choose a reason for hiding this comment

Uh oh!

jrvaldes commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 7, 2022

Uh oh!

jrvaldes commented Sep 7, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 7, 2022

Uh oh!

jrvaldes commented Sep 12, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 12, 2022

Uh oh!

jrvaldes commented Sep 12, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 12, 2022

Uh oh!

jrvaldes commented Sep 13, 2022

Uh oh!

openshift-cherrypick-robot commented Sep 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jrvaldes commented Aug 25, 2022 •

edited

Loading

jrvaldes commented Aug 29, 2022 •

edited

Loading

aravindhp commented Aug 31, 2022 •

edited by openshift-ci Bot

Loading

jrvaldes commented Sep 7, 2022 •

edited

Loading