Skip to content

[release-4.10] WINC-520: Stop downloading oc client and leverage test image binaries#1244

Merged
openshift-merge-robot merged 2 commits into
openshift:release-4.10from
jrvaldes:cherry-pick-1216-to-release-4.10
Sep 13, 2022
Merged

[release-4.10] WINC-520: Stop downloading oc client and leverage test image binaries#1244
openshift-merge-robot merged 2 commits into
openshift:release-4.10from
jrvaldes:cherry-pick-1216-to-release-4.10

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented Sep 12, 2022

This is a manual cherry-pick of #1216

@jrvaldes
[build] Stop downloading oc client
e3b1418 
This change leverages the introduction of the oc client in the test
images, making the build process simpler.

Follow-up to openshift/release#26395

(cherry picked from commit c1fa08c)
@jrvaldes
[hack] Ensure oc cli is present for e2e tests
a2c672a 
This change ensures the oc binary is present, or
fails otherwise. In addition, prints the location
and the version.

(cherry picked from commit bad87d2)
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2022 •
edited
Loading

@jrvaldes: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] WINC-520: Stop downloading oc client and leverage test image binaries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes jrvaldes marked this pull request as ready for review September 12, 2022 16:18
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2022
aravindhp
aravindhp approved these changes Sep 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, jrvaldes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 12, 2022

/retest-required

Remaining retests: 0 against base HEAD 9adcba7 and 2 for PR HEAD a2c672a in total

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Sep 13, 2022

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@jrvaldes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/azure-e2e-ccm-install a2c672a link false /test azure-e2e-ccm-install

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5e47344 into openshift:release-4.10 Sep 13, 2022
@jrvaldes jrvaldes deleted the cherry-pick-1216-to-release-4.10 branch May 19, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

1 more reviewer

@aravindhp aravindhp aravindhp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aravindhp aravindhp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jrvaldes @openshift-ci-robot @aravindhp @openshift-merge-robot