Skip to content

Use role instead of playbooks - 01-bootstrap.yml#2929

Merged
dasm merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:set-absolute-path-v3
May 12, 2025
Merged

Use role instead of playbooks - 01-bootstrap.yml#2929
dasm merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:set-absolute-path-v3

Conversation

@danpawlik
Copy link
Copy Markdown
Contributor

@danpawlik danpawlik commented Apr 28, 2025 •
edited
Loading

Most of the playbooks which are executed inside the nested Ansible (Ansible inside the Ansible) does not need to be in playbook, it can be in a simple role.
The previous CI execution for 01-bootstrap.yml file was:

Zuul CI ->
    Ansible command ->
    Ansible playbook ->
    import playbook ->
    import playbook

With this change would be one layer less:

Zuul CI ->
    Ansible command ->
    Ansible playbook ->
    cifmw_setup role

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Apr 28, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/afaa97a725e14fa8b16da6efdab616c3

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 44s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 14m 10s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 08s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 53s
❌ cifmw-pod-zuul-files FAILURE in 4m 47s
❌ cifmw-edpm-build-images FAILURE in 3m 54s
❌ cifmw-multinode-kuttl FAILURE in 1h 23m 18s
✔️ cifmw-tcib SUCCESS in 42m 58s
✔️ build-push-container-cifmw-client SUCCESS in 20m 48s
❌ cifmw-molecule-reproducer FAILURE in 4m 38s

@danpawlik danpawlik force-pushed the set-absolute-path-v3 branch from 2b647e0 to 6bbe0cc Compare April 29, 2025 09:43
@danpawlik danpawlik changed the title DNM Use role instead of playbooks to flatten Ansible execution Use role instead of playbooks - 01-bootstrap.yml Apr 29, 2025
@danpawlik danpawlik marked this pull request as ready for review April 29, 2025 09:43
@danpawlik danpawlik requested a review from a team as a code owner April 29, 2025 09:43
@danpawlik danpawlik force-pushed the set-absolute-path-v3 branch from 6bbe0cc to bd1f0b5 Compare April 29, 2025 12:34
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Apr 29, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fa49339cd3584c2db95fb999f351d514

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 40m 53s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 22s
✔️ cifmw-multinode-tempest SUCCESS in 1h 30m 42s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 24m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 21s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 00s
✔️ cifmw-edpm-build-images SUCCESS in 14m 21s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 30m 19s
✔️ cifmw-tcib SUCCESS in 41m 33s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 17m 12s
✔️ build-push-container-cifmw-client SUCCESS in 22m 00s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 26s
❌ cifmw-molecule-reproducer FAILURE in 13m 33s

@danpawlik danpawlik force-pushed the set-absolute-path-v3 branch 11 times, most recently from 19fa777 to 3d89333 Compare April 30, 2025 13:05
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Apr 30, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eac1882fc56f4dbd9c2b3c110ca49a28

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 05s
✔️ cifmw-multinode-tempest SUCCESS in 1h 30m 02s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 14m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 26s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 50s
✔️ cifmw-edpm-build-images SUCCESS in 14m 19s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 18m 13s
✔️ cifmw-tcib SUCCESS in 44m 01s
✔️ ci-framework-openstack-meta-content-provider SUCCESS in 17m 12s
✔️ build-push-container-cifmw-client SUCCESS in 21m 45s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 16s
❌ cifmw-molecule-reproducer FAILURE in 12m 16s

@danpawlik
Copy link
Copy Markdown
Contributor Author

danpawlik commented May 5, 2025

recheck

1 similar comment
@danpawlik
Copy link
Copy Markdown
Contributor Author

danpawlik commented May 5, 2025

recheck

@danpawlik danpawlik force-pushed the set-absolute-path-v3 branch 5 times, most recently from 6ea4171 to 4dbc790 Compare May 5, 2025 11:04
amartyasinha added a commit to amartyasinha/ci-framework that referenced this pull request Jun 3, 2025
@amartyasinha
Use role instead of playbooks - validations.yml
e4434ef 
Before simplifying 06-deploy-edpm.yml, it is necessary to take care of import_playbook calls within that play

There are three import_playbook calls within 06-deploy-edpm.yml
- validations.yml
- nfs.yml
- ceph.yml

This PR takes care of validations.yml

It is continuation of simplification job execution [1].

[1] openstack-k8s-operators#2929
@amartyasinha amartyasinha mentioned this pull request Jun 3, 2025
Merged
@amartyasinha amartyasinha mentioned this pull request Jun 4, 2025
Merged
amartyasinha added a commit to amartyasinha/ci-framework that referenced this pull request Jun 4, 2025
@amartyasinha
Use role instead of playbooks - nfs.yml
2f6ac33 
Before simplifying 06-deploy-edpm.yml, it is necessary to take care of import_playbook calls within that play

There are three import_playbook calls within 06-deploy-edpm.yml
- validations.yml
- nfs.yml
- ceph.yml

This PR takes care of nfs.yml

It is continuation of simplification job execution [1].

[1] openstack-k8s-operators#2929
@amartyasinha amartyasinha mentioned this pull request Jun 5, 2025
Closed
amartyasinha added a commit to amartyasinha/ci-framework that referenced this pull request Jun 9, 2025
@amartyasinha
Use role instead of playbooks - 03-build-packages.yml
c9f2f94 
It is continuation of simplification job execution [1].

[1] openstack-k8s-operators#2929
@amartyasinha amartyasinha mentioned this pull request Jun 9, 2025
Merged
amartyasinha added a commit to amartyasinha/ci-framework that referenced this pull request Jun 9, 2025
@amartyasinha
Use role instead of playbooks - 04-build-containers.yml
7be177d 
It is continuation of simplification job execution [1].

[1] openstack-k8s-operators#2929
@amartyasinha amartyasinha mentioned this pull request Jun 9, 2025
Merged
amartyasinha added a commit to amartyasinha/ci-framework that referenced this pull request Jun 9, 2025
@amartyasinha
Use role instead of playbooks - 05-build-operators.yml
5dc3b3f 
It is continuation of simplification job execution [1].

[1] openstack-k8s-operators#2929
@amartyasinha amartyasinha mentioned this pull request Jun 9, 2025
Merged
danpawlik pushed a commit that referenced this pull request Jun 11, 2025
@amartyasinha @danpawlik
Use role instead of playbooks - nfs.yml
16491ee 
Before simplifying 06-deploy-edpm.yml, it is necessary to take care of import_playbook calls within that play

There are three import_playbook calls within 06-deploy-edpm.yml
- validations.yml
- nfs.yml
- ceph.yml

This PR takes care of nfs.yml

It is continuation of simplification job execution [1].

[1] #2929
@amartyasinha amartyasinha mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dasm dasm dasm approved these changes

@evallesp evallesp evallesp approved these changes

@bshewale bshewale Awaiting requested review from bshewale

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@amartyasinha amartyasinha Awaiting requested review from amartyasinha

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danpawlik @dasm @evallesp