Skip to content

Use role instead of playbooks - nfs.yml#3038

Merged
danpawlik merged 1 commit intoopenstack-k8s-operators:mainfrom
amartyasinha:simplify-nfs
Jun 11, 2025
Merged

Use role instead of playbooks - nfs.yml#3038
danpawlik merged 1 commit intoopenstack-k8s-operators:mainfrom
amartyasinha:simplify-nfs

Conversation

@amartyasinha
Copy link
Copy Markdown
Contributor

@amartyasinha amartyasinha commented Jun 4, 2025

Before simplifying 06-deploy-edpm.yml, it is necessary to take care of import_playbook calls within that play

There are three import_playbook calls within 06-deploy-edpm.yml

  • validations.yml
  • nfs.yml
  • ceph.yml

This PR takes care of nfs.yml

It is continuation of simplification job execution [1].

[1] #2929

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/145bc438ed3949adbc99ad7c535f3fc7

✔️ openstack-k8s-operators-content-provider SUCCESS in 40m 57s
podified-multinode-edpm-deployment-crc FAILURE in 17m 20s
cifmw-crc-podified-edpm-baremetal FAILURE in 19m 02s
podified-multinode-hci-deployment-crc FAILURE in 21m 44s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 26m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 07s
cifmw-pod-pre-commit FAILURE in 8m 08s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 54s
✔️ build-push-container-cifmw-client SUCCESS in 22m 24s
cifmw-molecule-cifmw_nfs FAILURE in 4m 24s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8191d0aef3944e54985e69b0cf06455e

✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 08s
podified-multinode-edpm-deployment-crc FAILURE in 16m 59s
cifmw-crc-podified-edpm-baremetal FAILURE in 24m 18s
podified-multinode-hci-deployment-crc FAILURE in 23m 52s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 27m 38s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 23s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 37s
✔️ build-push-container-cifmw-client SUCCESS in 23m 14s

Before simplifying 06-deploy-edpm.yml, it is necessary to take care of import_playbook calls within that play

There are three import_playbook calls within 06-deploy-edpm.yml
- validations.yml
- nfs.yml
- ceph.yml

This PR takes care of nfs.yml

It is continuation of simplification job execution [1].

[1] openstack-k8s-operators#2929
@amartyasinha amartyasinha marked this pull request as ready for review June 4, 2025 08:55
@amartyasinha amartyasinha requested a review from a team as a code owner June 4, 2025 08:55
@amartyasinha amartyasinha changed the title DNM: Use role instead of playbooks - nfs.yml Use role instead of playbooks - nfs.yml Jun 4, 2025
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ddad18241064862b0d12cb701c44037

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 30m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 55s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 50m 35s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 45m 51s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 14m 35s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 24s
✔️ build-push-container-cifmw-client SUCCESS in 22m 23s

@amartyasinha
Copy link
Copy Markdown
Contributor Author

recheck cifmw-crc-podified-edpm-baremetal

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/801583e25d654e61b40a07b98010ac6c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 34s
podified-multinode-hci-deployment-crc RETRY_LIMIT in 4m 00s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 42m 15s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 21s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 45s
✔️ build-push-container-cifmw-client SUCCESS in 17m 35s

@amartyasinha
Copy link
Copy Markdown
Contributor Author

recheck

@amartyasinha amartyasinha requested a review from danpawlik June 9, 2025 04:57
Comment thread playbooks/06-deploy-edpm.yml
@danpawlik danpawlik merged commit 16491ee into openstack-k8s-operators:main Jun 11, 2025
7 checks passed
danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Jun 12, 2025
After merging [1] [2] it seems the CI job did not trigger
tests for verifying molecule roles.

[1] openstack-k8s-operators#3038
[2] openstack-k8s-operators#3020

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik added a commit that referenced this pull request Jun 12, 2025
After merging [1] [2] it seems the CI job did not trigger
tests for verifying molecule roles.

[1] #3038
[2] #3020

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@tosky
Copy link
Copy Markdown
Contributor

tosky commented Jun 17, 2025

This change broke the export of cifmw_nfs_ip. Please double check the code, or revert for now.

danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Jun 23, 2025
The target var should be "computes", not "compute".
It raises an issue that later the host is skipped by the Ansible.

This commit fixes porting issue raised in Pull Request [1].

[1] openstack-k8s-operators#3038

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik added a commit that referenced this pull request Jun 24, 2025
The target var should be "computes", not "compute".
It raises an issue that later the host is skipped by the Ansible.

This commit fixes porting issue raised in Pull Request [1].

[1] #3038

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@amartyasinha amartyasinha deleted the simplify-nfs branch January 9, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants