Skip to content

Fix the default value of cifmw_nfs_target#3076

Merged
danpawlik merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:check-compute-group
Jun 24, 2025
Merged

Fix the default value of cifmw_nfs_target#3076
danpawlik merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:check-compute-group

Conversation

@danpawlik
Copy link
Copy Markdown
Contributor

@danpawlik danpawlik commented Jun 18, 2025

Change default variable value for cifmw_nfs role

The target var should be "computes", not "compute".
It raises an issue that later the host is skipped by the Ansible.

This commit fixes porting issue raised in Pull Request [1].

[1] #3038

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3e8c4f0e3da44d981eb68c7a812f8d9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 57s
podified-multinode-edpm-deployment-crc FAILURE in 59m 25s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 29m 57s
podified-multinode-hci-deployment-crc FAILURE in 51m 09s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 42m 42s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 38s
cifmw-pod-pre-commit FAILURE in 7m 43s
build-push-container-cifmw-client FAILURE in 15m 58s

@amartyasinha amartyasinha force-pushed the check-compute-group branch from a2969a5 to bd5d3d3 Compare June 20, 2025 08:46
@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3076,bd5d3d39fdfe269e63b09d660438056d62d3c103

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/518079e53b88475fbf8a721fba184d80

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 35s
podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 27s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 34m 05s
podified-multinode-hci-deployment-crc FAILURE in 51m 34s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 47m 19s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 19s
✔️ build-push-container-cifmw-client SUCCESS in 15m 36s
✔️ cifmw-molecule-cifmw_nfs SUCCESS in 2m 21s

@danpawlik danpawlik force-pushed the check-compute-group branch from b03a0d0 to f4d5cd4 Compare June 23, 2025 06:41
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b689461f6657418ba50c5b1f08589836

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 57s
podified-multinode-edpm-deployment-crc FAILURE in 56m 39s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 29m 16s
podified-multinode-hci-deployment-crc FAILURE in 49m 17s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 42m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
cifmw-pod-pre-commit FAILURE in 8m 13s
✔️ build-push-container-cifmw-client SUCCESS in 18m 39s
✔️ cifmw-molecule-cifmw_nfs SUCCESS in 2m 15s

@danpawlik danpawlik force-pushed the check-compute-group branch 2 times, most recently from cebf9d2 to e70be7e Compare June 23, 2025 11:04
@danpawlik danpawlik changed the title DNM Checking nfs hosts Change default variable value for cifmw_nfs role Jun 23, 2025
@danpawlik danpawlik marked this pull request as ready for review June 23, 2025 14:51
@danpawlik danpawlik requested a review from a team as a code owner June 23, 2025 14:51
@tosky
Copy link
Copy Markdown
Contributor

tosky commented Jun 23, 2025

Ok, looking at https://github.com/openstack-k8s-operators/ci-framework/pull/3038/files I understand this was a porting error.
Please add a comment to the commit message saying this fixes a porting error from #3038

@danpawlik danpawlik changed the title Change default variable value for cifmw_nfs role Fix the default value of cifmw_nfs_target Jun 23, 2025
@danpawlik danpawlik force-pushed the check-compute-group branch from e70be7e to 6a8645d Compare June 23, 2025 15:10
The target var should be "computes", not "compute".
It raises an issue that later the host is skipped by the Ansible.

This commit fixes porting issue raised in Pull Request [1].

[1] openstack-k8s-operators#3038

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik force-pushed the check-compute-group branch from 6a8645d to 7dd5f15 Compare June 23, 2025 15:18
@tosky tosky added the lgtm label Jun 23, 2025
@tosky
Copy link
Copy Markdown
Contributor

tosky commented Jun 23, 2025

Thank you!

@danpawlik danpawlik merged commit ad6505a into openstack-k8s-operators:main Jun 24, 2025
5 checks passed
@danpawlik danpawlik deleted the check-compute-group branch June 24, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants