Fix the default value to import cifmw_nfs role#3073
Fix the default value to import cifmw_nfs role#3073amartyasinha wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
amartyasinha
changed the title
|
But this is not correct: by default the NFS server should not be deployed. |
| nftables_conf: /etc/sysconfig/nftables.conf | ||
| when: | ||
| - cifmw_edpm_deploy_nfs | default('false') | bool | ||
| - cifmw_edpm_deploy_nfs | default('true') | bool |
There was a problem hiding this comment.
The default value MUST not be changed. The NFS server must not be deployed by default.
The problem is that cifmw_edpm_deploy_nfs is set by a consumer of this code but not considered.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b319f6e1a42c4b6fa2a38d285443babc ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 47s |
2 participants
Due to wrong default value in when condition, cifmw_nfs role was getting skipped, thus other required tasks were also getting skipped (For example,
cifmw_nfs_ipvar is set to the file during cifmw_nfs role / or earlier through nfs.yml playbook)This PR fixes the issue caused through #3038