Skip to content

Allow bmh cleanup and move cleanup to role#3020

Merged
eshulman2 merged 1 commit intoopenstack-k8s-operators:mainfrom
eshulman2:cleanup_bmh
Jun 11, 2025
Merged

Allow bmh cleanup and move cleanup to role#3020
eshulman2 merged 1 commit intoopenstack-k8s-operators:mainfrom
eshulman2:cleanup_bmh

Conversation

@eshulman2
Copy link
Copy Markdown
Contributor

@eshulman2 eshulman2 commented May 29, 2025 •
edited
Loading

  • Allow cleanup of baremetal hosts (BMH) in OpenStack deployments. (required due to bug/change in OCP 4.18)
  • Move cleanup tasks to a dedicated Ansible role for better organization and reusability.
  • reduce cleanup time by deataching BMHs from the cluster before removing them.

@eshulman2 eshulman2 requested review from a team as code owners May 29, 2025 15:53
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eshulman2 eshulman2 marked this pull request as draft May 29, 2025 15:54
@eshulman2 eshulman2 force-pushed the cleanup_bmh branch 7 times, most recently from 5a79f6f to cd63bfd Compare May 29, 2025 16:29
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented May 29, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db32e655e7944ad991bab045e4a48b7c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 56s
❌ cifmw-multinode-tempest FAILURE in 2h 09m 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 37s
❌ cifmw-pod-pre-commit FAILURE in 8m 47s
✔️ build-push-container-cifmw-client SUCCESS in 21m 56s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 29s

@eshulman2 eshulman2 force-pushed the cleanup_bmh branch 7 times, most recently from 0214428 to be35c8b Compare June 3, 2025 09:31
@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 3, 2025

this patch is based on #3018

@eshulman2 eshulman2 changed the title Cleanup bmh Allow bmh cleanup and move cleanup to role Jun 3, 2025
@eshulman2 eshulman2 marked this pull request as ready for review June 3, 2025 09:38
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0f736db17303409fbae4f2a4cc523b32

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 41m 20s
❌ cifmw-multinode-tempest FAILURE in 2h 01m 25s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 15s
❌ cifmw-pod-pre-commit FAILURE in 8m 34s
✔️ build-push-container-cifmw-client SUCCESS in 22m 03s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 34s

@eshulman2 eshulman2 force-pushed the cleanup_bmh branch 4 times, most recently from c9ea3d9 to f09ceca Compare June 8, 2025 11:22
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 8, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ca1663daf004f96b26a0860da14f87b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 44s
❌ cifmw-multinode-tempest FAILURE in 2h 05m 05s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
❌ cifmw-pod-pre-commit FAILURE in 7m 50s
✔️ build-push-container-cifmw-client SUCCESS in 17m 37s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 19s

@eshulman2 eshulman2 force-pushed the cleanup_bmh branch 3 times, most recently from 37f163e to 103a877 Compare June 9, 2025 09:57
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 9, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/80fc6947d41341548f02b260698266b9

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 50s
❌ cifmw-multinode-tempest FAILURE in 2h 10m 14s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 23s
✔️ build-push-container-cifmw-client SUCCESS in 17m 57s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 28s

@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 9, 2025

recheck

danpawlik
danpawlik reviewed Jun 9, 2025
View reviewed changes
Comment thread roles/cleanup_openstack/tasks/main.yaml Outdated
@danpawlik
Copy link
Copy Markdown
Contributor

danpawlik commented Jun 9, 2025

Waiting for CI results, but so far, good job!

@eshulman2 eshulman2 requested a review from danpawlik June 10, 2025 06:09
@eshulman2
Allow bmh cleanup and move cleanup to role
cde744e 
- Allow cleanup of baremetal hosts (BMH) in OpenStack deployments. (required due to bug/change in OCP 4.18)
- Move cleanup tasks to a dedicated Ansible role for better organization and reusability.
- reduce cleanup time by deataching BMHs from the cluster before removing them.
@eshulman2 eshulman2 enabled auto-merge (rebase) June 10, 2025 11:02
sdatko
sdatko approved these changes Jun 10, 2025
View reviewed changes
Comment thread roles/cleanup_openstack/tasks/main.yaml Outdated
@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 10, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/22b3b88c5a0046819ccee3ffa7dd5906

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 38s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 52m 40s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 21m 44s

@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 10, 2025

recheck

@eshulman2 eshulman2 merged commit 109056b into openstack-k8s-operators:main Jun 11, 2025
5 checks passed
danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Jun 12, 2025
@danpawlik
Add missing molecule jobs
7a51cc5 
After merging [1] [2] it seems the CI job did not trigger
tests for verifying molecule roles.

[1] openstack-k8s-operators#3038
[2] openstack-k8s-operators#3020

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik mentioned this pull request Jun 12, 2025
Merged
danpawlik added a commit that referenced this pull request Jun 12, 2025
@danpawlik
Add missing molecule jobs
14950c1 
After merging [1] [2] it seems the CI job did not trigger
tests for verifying molecule roles.

[1] #3038
[2] #3020

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danpawlik danpawlik danpawlik approved these changes

@sdatko sdatko sdatko approved these changes

@bshewale bshewale Awaiting requested review from bshewale

@amartyasinha amartyasinha Awaiting requested review from amartyasinha

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eshulman2 @danpawlik @sdatko