Skip to content

Enable cleanup for test operator#3018

Merged
eshulman2 merged 1 commit intoopenstack-k8s-operators:mainfrom
eshulman2:test_operator_cleanup
Jun 10, 2025
Merged

Enable cleanup for test operator#3018
eshulman2 merged 1 commit intoopenstack-k8s-operators:mainfrom
eshulman2:test_operator_cleanup

Conversation

@eshulman2
Copy link
Copy Markdown
Contributor

@eshulman2 eshulman2 commented May 28, 2025 •
edited
Loading

This patch is meant to allow independent cleanup of resources created by the test operator.

  • Use files to manage CRs
  • Add cleanup tasks to remove CRs and resources created by test operator
  • Reduce redundant evaluations in test_operator role
  • Split functionalities to different tasks files

@eshulman2 eshulman2 requested review from a team as code owners May 28, 2025 10:12
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch 2 times, most recently from a0b96ed to 5ee2071 Compare May 28, 2025 10:37
@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch from 5ee2071 to e3b9547 Compare May 29, 2025 10:18
@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch from e3b9547 to 13eb503 Compare May 29, 2025 10:35
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented May 29, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3fe998c17ff45bf97d0359432ea010a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 43s
❌ cifmw-multinode-tempest FAILURE in 2h 07m 22s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 48s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 36s
✔️ build-push-container-cifmw-client SUCCESS in 22m 26s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 31s

@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented May 29, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented May 29, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/93f2449e43a94cb8a1522f01e20d1a73

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 24s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 35m 45s
❌ cifmw-multinode-tempest FAILURE in 2h 06m 42s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 14s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 39s
✔️ build-push-container-cifmw-client SUCCESS in 17m 26s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 31s

@sdatko sdatko requested a review from kstrenkova June 2, 2025 07:52
@sdatko
Copy link
Copy Markdown
Contributor

sdatko commented Jun 2, 2025

@kstrenkova Please check this one 🙏 👍 ❤️ 🚀 🥇

@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch from 13eb503 to 8a9c737 Compare June 3, 2025 06:37
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d143831d01b41858bdf65c8ef562144

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 30s
❌ cifmw-multinode-tempest FAILURE in 2h 08m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 50s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 05s
✔️ build-push-container-cifmw-client SUCCESS in 18m 02s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 30s

@eshulman2 eshulman2 mentioned this pull request Jun 3, 2025
Merged
@evallesp
Copy link
Copy Markdown
Contributor

evallesp commented Jun 3, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6ce3ae17a3b74134874c566be71a6559

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 17m 27s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 28s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 44s
❌ cifmw-multinode-tempest FAILURE in 2h 03m 06s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 16s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 16s
✔️ build-push-container-cifmw-client SUCCESS in 17m 32s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 25s

kstrenkova
kstrenkova reviewed Jun 4, 2025
View reviewed changes
Comment thread roles/test_operator/README.md Outdated
Comment thread roles/test_operator/tasks/cleanup_run.yaml Outdated
@eshulman2 eshulman2 requested a review from kstrenkova June 4, 2025 12:02
@eshulman2 eshulman2 enabled auto-merge (rebase) June 4, 2025 12:18
@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 4, 2025

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 4, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d3a80bc1834b45598f6cead9e72f65d2

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 56s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 45s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 02m 23s
❌ cifmw-multinode-tempest FAILURE in 2h 08m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 33s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 28s
✔️ build-push-container-cifmw-client SUCCESS in 22m 44s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 44s

@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 5, 2025

recheck

@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch from 8a9c737 to c9736d8 Compare June 5, 2025 06:37
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1e82231107f142d7b342e1579c1656eb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 30m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 56s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 24s
❌ cifmw-multinode-tempest FAILURE in 2h 11m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 10s
✔️ build-push-container-cifmw-client SUCCESS in 21m 52s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 25s

@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch 2 times, most recently from c59f0d7 to 2c30fcb Compare June 8, 2025 10:51
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 8, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4cf7d01bd2dd4118aa18cbc2b56eac3e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 55s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 17s
❌ cifmw-multinode-tempest FAILURE in 2h 07m 04s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 34s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 46s
✔️ build-push-container-cifmw-client SUCCESS in 21m 18s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 25s

@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch 2 times, most recently from 5d68285 to 51d499c Compare June 9, 2025 08:25
@eshulman2
Enable cleanup for test operator
7b177b8 
This patch is meant to allow independent cleanup of resources created by the test operator.

- Use files to manage CRs
- Add cleanup tasks to remove CRs and resources created by test operator
- Reduce redundant evaluations in test_operator role
@eshulman2 eshulman2 force-pushed the test_operator_cleanup branch from 51d499c to 7b177b8 Compare June 9, 2025 09:58
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Jun 9, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cee04573950e4419aaed53405abc80c7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 02s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 35s
❌ cifmw-multinode-tempest FAILURE in 2h 06m 05s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 08s
✔️ build-push-container-cifmw-client SUCCESS in 17m 37s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 24s

@eshulman2
Copy link
Copy Markdown
Contributor Author

eshulman2 commented Jun 9, 2025

recheck

danpawlik
danpawlik reviewed Jun 10, 2025
View reviewed changes
Comment thread roles/test_operator/tasks/collect-logs.yaml
sdatko
sdatko approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me 🍕 🎈 🧷

@eshulman2 eshulman2 merged commit 6c6a85a into openstack-k8s-operators:main Jun 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danpawlik danpawlik danpawlik approved these changes

@sdatko sdatko sdatko approved these changes

@kstrenkova kstrenkova kstrenkova approved these changes

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eshulman2 @sdatko @evallesp @danpawlik @kstrenkova