Skip to content

Improve warning comment in playbooks#3098

Merged
evallesp merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:improve-comment
Jul 9, 2025
Merged

Improve warning comment in playbooks#3098
evallesp merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:improve-comment

Conversation

@danpawlik
Copy link
Copy Markdown
Contributor

The comment should better warn of future plans.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danpawlik
Copy link
Copy Markdown
Contributor Author

danpawlik commented Jun 30, 2025

Require #3066 to be merged. Then rebase and:

find playbooks/ -type f -exec sed -i 's/DO NOT EDIT THAT PLAYBOOK. IT WOULD BE REMOVED IN NEAR FUTURE/DO NOT EDIT THIS PLAYBOOK. IT WILL BE REMOVED IN NEAR FUTURE./g' {} \;

EDIT:
already fixed in 3066

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d3badb6b709f487db68646e7cddfc904

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 56s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 38s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 28m 15s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 36m 48s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 45s
build-push-container-cifmw-client POST_FAILURE in 43m 20s

The comment should better warn of future plans.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik marked this pull request as ready for review July 8, 2025 17:41
@danpawlik danpawlik requested a review from a team as a code owner July 8, 2025 17:41
@danpawlik
Copy link
Copy Markdown
Contributor Author

recheck

@evallesp evallesp merged commit b7db8d2 into openstack-k8s-operators:main Jul 9, 2025
5 of 6 checks passed
Copy link
Copy Markdown
Contributor

@brjackma brjackma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants