Use role instead of playbooks - 06-deploy-architecture.yml by danpawlik · Pull Request #3066 · openstack-k8s-operators/ci-framework

danpawlik · 2025-06-12T07:13:01Z

Reason why we move playbook execution to roles was described in pull request [1], but in few words: it would be easier for mainteners to understand playbook/role execution, it is just better to control variables, easier to debug, etc.

[1] #2930

openshift-ci · 2025-06-12T07:13:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

softwarefactory-project-zuul · 2025-06-12T10:42:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/edeed835e56843f9b274b57cc8c90fda

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 58m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 40s
❌ podified-multinode-hci-deployment-crc FAILURE in 57m 36s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 12m 54s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 46s
✔️ build-push-container-cifmw-client SUCCESS in 18m 43s
✔️ cifmw-molecule-ci_lvms_storage SUCCESS in 2m 28s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 28s

danpawlik · 2025-06-12T13:57:51Z

recheck

softwarefactory-project-zuul · 2025-06-16T12:12:23Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5199f31a44644c078a69cad6e45d8348

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 43m 59s
❌ podified-multinode-edpm-deployment-crc FAILURE in 57m 53s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 19m 35s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 2h 30m 53s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 20s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 19s
✔️ build-push-container-cifmw-client SUCCESS in 18m 42s
✔️ cifmw-molecule-ci_lvms_storage SUCCESS in 2m 18s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 17s

danpawlik · 2025-06-18T09:00:38Z

recheck

softwarefactory-project-zuul · 2025-06-18T09:00:46Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 3066,f867e17bf8698e37bf70e64fb3baa79e77315923

fmount · 2025-06-30T11:45:18Z

a minor comment but not blocking in case is not relevant for multi-namespace VA

fultonj · 2025-06-30T11:50:02Z

On controller-0, a shell script called deploy-architecture.sh is created and we have the option to run that script separately. That script calls the deploy-edpm.yaml playbook. Is there any plan to change that?

[zuul@controller-0 ~]$ cat deploy-architecture.sh 
#!/bin/bash
set -e
pushd /home/zuul/src/github.com/openstack-k8s-operators/ci-framework
export ANSIBLE_LOG_PATH="~/ansible-deploy-architecture.log"

ansible-playbook -i ~/ci-framework-data/artifacts/zuul_inventory.yml \
  -e @~/ci-framework-data/parameters/reproducer-variables.yml \
  -e @~/ci-framework-data/parameters/openshift-environment.yml \
  deploy-edpm.yml --flush-cache $@
popd
[zuul@controller-0 ~]$

danpawlik · 2025-06-30T12:14:42Z

On controller-0, a shell script called deploy-architecture.sh is created and we have the option to run that script separately. That script calls the deploy-edpm.yaml playbook. Is there any plan to change that?
[zuul@controller-0 ~]$ cat deploy-architecture.sh 
#!/bin/bash
set -e
pushd /home/zuul/src/github.com/openstack-k8s-operators/ci-framework
export ANSIBLE_LOG_PATH="~/ansible-deploy-architecture.log"

ansible-playbook -i ~/ci-framework-data/artifacts/zuul_inventory.yml \
  -e @~/ci-framework-data/parameters/reproducer-variables.yml \
  -e @~/ci-framework-data/parameters/openshift-environment.yml \
  deploy-edpm.yml --flush-cache $@
popd
[zuul@controller-0 ~]$ 

so far, we don't touch deploy*-.yml playbooks.

Reason why we move playbook execution to roles was described in pull request [1], but in few words: it would be easier for mainteners to understand playbook/role execution, it is just better to control variables, easier to debug, etc. [1] openstack-k8s-operators#2930 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>

softwarefactory-project-zuul · 2025-06-30T14:03:54Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a51dabd8e3d44d508138a5570a1f52a8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 48s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 35m 10s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 47s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 43s
❌ build-push-container-cifmw-client FAILURE in 17m 50s
✔️ cifmw-molecule-ci_lvms_storage SUCCESS in 2m 23s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 20s

danpawlik · 2025-06-30T14:48:26Z

recheck

softwarefactory-project-zuul · 2025-06-30T16:35:13Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/194319289ac54ea684e6df9657c557df

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 56s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 10s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 35m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 37s
✔️ build-push-container-cifmw-client SUCCESS in 15m 07s
✔️ cifmw-molecule-ci_lvms_storage SUCCESS in 1m 49s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 19s

danpawlik · 2025-07-07T06:48:08Z

recheck

abays

/lgtm

danpawlik requested review from a team, abays, fmount and fultonj as code owners June 12, 2025 07:13

evallesp previously approved these changes Jun 12, 2025

View reviewed changes

Comment thread deploy-edpm.yml Outdated

github-actions Bot added the Ready For Review label Jun 12, 2025

danpawlik dismissed evallesp’s stale review via c38ea31 June 13, 2025 06:29

danpawlik force-pushed the move-06-play branch from 43ea14c to c38ea31 Compare June 13, 2025 06:29

github-actions Bot added Ready For Review and removed Ready For Review labels Jun 13, 2025

amartyasinha reviewed Jun 16, 2025

View reviewed changes

Comment thread roles/cifmw_setup/tasks/deploy_architecture.yml Outdated

Comment thread playbooks/06-deploy-edpm.yml Outdated

danpawlik force-pushed the move-06-play branch from c38ea31 to ae7de4b Compare June 16, 2025 07:34

github-actions Bot removed the Ready For Review label Jun 16, 2025

amartyasinha previously approved these changes Jun 16, 2025

View reviewed changes

evallesp previously approved these changes Jun 16, 2025

View reviewed changes

danpawlik changed the title ~~Use role instead of playbooks - 06-deploy-edpm.yml~~ Use role instead of playbooks - 06-deploy-architecture.yml Jun 16, 2025

danpawlik dismissed stale reviews from evallesp and amartyasinha via a64b53b June 16, 2025 09:26

danpawlik force-pushed the move-06-play branch 2 times, most recently from a64b53b to f867e17 Compare June 16, 2025 09:26

amartyasinha previously approved these changes Jun 16, 2025

View reviewed changes

openshift-merge-robot added the needs-rebase label Jun 17, 2025

danpawlik dismissed amartyasinha’s stale review via fa629a6 June 23, 2025 08:08

abays reviewed Jun 30, 2025

View reviewed changes

Comment thread playbooks/06-deploy-architecture.yml Outdated

fmount reviewed Jun 30, 2025

View reviewed changes

Comment thread roles/cifmw_setup/tasks/deploy_architecture.yml Outdated

danpawlik mentioned this pull request Jun 30, 2025

Improve warning comment in playbooks #3098

Merged

danpawlik dismissed stale reviews from bshewale, evallesp, and amartyasinha via 3b63963 June 30, 2025 12:22

danpawlik force-pushed the move-06-play branch from 9d20015 to 3b63963 Compare June 30, 2025 12:22

github-actions Bot removed the Ready For Review label Jun 30, 2025

danpawlik requested review from abays, evallesp and fmount June 30, 2025 12:23

github-actions Bot added the Ready For Review label Jul 7, 2025

amartyasinha approved these changes Jul 7, 2025

View reviewed changes

brjackma approved these changes Jul 7, 2025

View reviewed changes

danpawlik disabled auto-merge July 7, 2025 15:39

danpawlik enabled auto-merge (rebase) July 7, 2025 15:40

michburk approved these changes Jul 7, 2025

View reviewed changes

abays approved these changes Jul 7, 2025

View reviewed changes

danpawlik merged commit b18133a into openstack-k8s-operators:main Jul 7, 2025
5 checks passed

openshift-ci Bot assigned abays Jul 7, 2025

openshift-ci Bot added the lgtm label Jul 7, 2025

danpawlik deleted the move-06-play branch July 7, 2025 18:06

Conversation

danpawlik commented Jun 12, 2025

Uh oh!

openshift-ci Bot commented Jun 12, 2025

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Jun 12, 2025

Uh oh!

danpawlik commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul Bot commented Jun 16, 2025

Uh oh!

danpawlik commented Jun 18, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

fmount commented Jun 30, 2025

Uh oh!

fultonj commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danpawlik commented Jun 30, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jun 30, 2025

Uh oh!

danpawlik commented Jun 30, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jun 30, 2025

Uh oh!

danpawlik commented Jul 7, 2025

Uh oh!

abays left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

fultonj commented Jun 30, 2025 •

edited

Loading