Change the way how the hooks playbook is executed#2930
Change the way how the hooks playbook is executed#2930dasm merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
remove-hooks-play
branch
from
ab89064 to
2aea2b3
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d386e780a9974f9d8611e68be58fcf43 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 34s |
danpawlik
force-pushed
the
remove-hooks-play
branch
from
2aea2b3 to
d6ea64e
Compare
In many places, it was done that Ansible playbook is importing another ansible playbook, which is importing again another playbook and another. It is too complex and after doing simple improvement as it was done in this change by removing import_playbook: hooks.yml, we see that those tasks can be running in same play. With that approach we can: - easy understand playbook/role execution, - better control variables, - in some part faster execution due there is no need to make delegation or gather_facts, - easier to debug Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
remove-hooks-play
branch
from
d6ea64e to
e64c9f2
Compare
The playbooks were migrated into role cifmw_setup. As it was mentioned in commit message [1], such approach should be better for developers to maintain the code. Also skip removing 08-run-tests.yml because the NFV team is using it and it takes a time to verify that. The playbook would be removed in next pull request. [1] openstack-k8s-operators#2930 Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/58147 Depends-On: openstack-k8s-operators#3208 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
The playbooks were migrated into role cifmw_setup. As it was mentioned in commit message [1], such approach should be better for developers to maintain the code. Also skip removing 08-run-tests.yml because the NFV team is using it and it takes a time to verify that. The playbook would be removed in next pull request. [1] #2930 Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/58147 Depends-On: #3208 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
4 participants
In many places, it was done that Ansible playbook is importing another ansible playbook, which is importing again another playbook and another. It is too complex and after doing simple improvement as it was done in this change by removing import_playbook: hooks.yml, we see that those tasks can be running in same play.
With that approach we can: