Run nested ansible command and call run_logs tasks to drop 99-logs play#3208
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
improve-e2e-collect-logs-after-dropping-ansible-cmd
branch
from
d72eb99 to
c8ca7b9
Compare
danpawlik
force-pushed
the
improve-e2e-collect-logs-after-dropping-ansible-cmd
branch
from
c8ca7b9 to
4188839
Compare
|
this version is still missing the must-gather logs: https://logserver.rdoproject.org/dce/rdoproject.org/dce68e40e56e4814aae7623b7c2447ca/controller/ci-framework-data/logs/. Looking at the job output: https://softwarefactory-project.io/zuul/t/rdoproject.org/build/dce68e40e56e4814aae7623b7c2447ca/log/job-output.txt#7411 it looks like all the tasks from the |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4b3a4519358049b0900811bd04194d10 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 08s |
danpawlik
force-pushed
the
improve-e2e-collect-logs-after-dropping-ansible-cmd
branch
2 times, most recently
from
e5f4682 to
052eacc
Compare
|
Some part of the code, where was partially done migration from nested ansible to call role directly was splited into few pieces, first part related to helpers: #3235 |
|
confirmed with @cescgina that openstack-k8s-operators/watcher-operator#251 provides missing logs. Checking, if the 251 requires additional changes in "empty" watcher operator change openstack-k8s-operators/watcher-operator#258 |
danpawlik
force-pushed
the
improve-e2e-collect-logs-after-dropping-ansible-cmd
branch
from
052eacc to
f99c72f
Compare
Earlier the 99-logs.yml playbook was executed as nested Ansible. After we migrate that playbook to role, it can not be called directly, because it contains: cimfw collection to be installed on Zuul executor and include_vars can not read files, that are located on the controller, so they needs to be synchronized with Zuul executor job dir. Also fix condition that was changed when moving 99-logs.yml play into the role. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
improve-e2e-collect-logs-after-dropping-ansible-cmd
branch
from
f99c72f to
30f082f
Compare
…ck-k8s-operators#251 Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231
danpawlik
requested review from
amartyasinha,
brjackma,
dasm,
evallesp and
michburk
danpawlik
deleted the
improve-e2e-collect-logs-after-dropping-ansible-cmd
branch
…ck-k8s-operators#251 Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231
6 participants
Earlier the 99-logs.yml playbook was executed as nested Ansible.
After we migrate that playbook to role, it can not be called directly,
because it contains: cimfw collection to be installed on Zuul executor
and include_vars can not read files, that are located on the controller,
so they needs to be synchronized with Zuul executor job dir.