Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Aug 20, 2025
Due to this change [1] os-must-gather logs was not logged because of some var issues. so reverting that partial part of code in this PR will fix the issue[2]. [1]: https://github.com/openstack-k8s-operators/ci-framework/pull/3032/files#diff-691dae244b4fb4bfc1270fb5d3b708c6be6073b0e33d997db15850edfa3fd976L23 [2]: https://logserver.rdoproject.org/88f/rdoproject.org/88f54e6882384b2a88e9bfadffa3ff02/controller/ci-framework-data/logs/
bshewale
force-pushed
the
move-99-logs-playbook-into-role
branch
from
d4f9467 to
a035204
Compare
bshewale
changed the title
evallesp
approved these changes
Aug 20, 2025
cescgina
approved these changes
Aug 20, 2025
danpawlik
changed the title
Contributor
|
so please wait, I will do a quick fix. |
danpawlik
requested changes
Aug 21, 2025
Contributor
danpawlik
left a comment
danpawlik
left a comment
There was a problem hiding this comment.
let me do a quick fix.
Contributor
|
Checking here: #3208 |
danpawlik
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to this change 1 os-must-gather logs was not logged
because of some var issues.
so reverting that partial part of code in this PR will fix the
issue2.