Remove condition from run_logs tasks of cifmw_setup#3204
Remove condition from run_logs tasks of cifmw_setup#3204cescgina wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
thank you |
|
/hold this is not working yet, needs more changes |
cescgina
dismissed stale reviews from bshewale, fmount, evallesp, danpawlik, and amartyasinha
via
e6bd4f3
cescgina
force-pushed
the
restore_logging_cifmw_setup
branch
from
91a4b3a to
e6bd4f3
Compare
|
New changes are detected. LGTM label has been removed. |
After merging[1], jobs have stopped running must-gather to collect service logs, e.g [2,3]. This seems to be caused by the change in [4]. Where before the 99-logs.yml playbook was run from an 'ansible-playbook' invocation, without any inventory and thus the check for 'zuul_log_collection' was never triggered because the variable was never set. Now, when importing the cifmw_setup role, the cifmw variables are loaded and that variable which is in most jobs set to True prevents the log collection, and most critically, must-gather collection. This change removes the condition to preserve the previous behaviour. [1] openstack-k8s-operators#3032 [2] https://softwarefactory-project.io/zuul/t/rdoproject.org/build/63673310b4f94883a9aff2db719a2095 [3] https://softwarefactory-project.io/zuul/t/rdoproject.org/build/03e87102fbf04dc7b482ecdba7128085 [4] openstack-k8s-operators@cc87f54#diff-691dae244b4fb4bfc1270fb5d3b708c6be6073b0e33d997db15850edfa3fd976L23
cescgina
force-pushed
the
restore_logging_cifmw_setup
branch
from
e6bd4f3 to
e09cac1
Compare
|
I don't think this approach will work. There are calls to |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/55d8ff7b77d6434aa39a90f048a1f6c9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 18s |
Pull request was closed
|
Closing this in favor of #3206 |
6 participants
After merging[1], jobs have stopped running must-gather to collect
service logs, e.g [2,3]. This seems to be caused by the change in [4].
Where before the 99-logs.yml playbook was run from an 'ansible-playbook'
invocation, without any inventory and thus the check for
'zuul_log_collection' was never triggered because the variable was never
set. Now, when importing the cifmw_setup role, the cifmw variables are
loaded and that variable which is in most jobs set to True prevents the
log collection, and most critically, must-gather collection.
This change removes the condition to preserve the previous behaviour.
[1] #3032
[2] https://softwarefactory-project.io/zuul/t/rdoproject.org/build/63673310b4f94883a9aff2db719a2095
[3] https://softwarefactory-project.io/zuul/t/rdoproject.org/build/03e87102fbf04dc7b482ecdba7128085
[4] cc87f54#diff-691dae244b4fb4bfc1270fb5d3b708c6be6073b0e33d997db15850edfa3fd976L23