Skip to content

Add cifmw_helpers role#3235

Merged
bshewale merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:add-cifmw-helpers
Sep 12, 2025
Merged

Add cifmw_helpers role#3235
bshewale merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:add-cifmw-helpers

Conversation

@danpawlik
Copy link
Copy Markdown
Contributor

@danpawlik danpawlik commented Aug 28, 2025

The new role would provide tasks that would be helpful to drop nested Ansible execution in the project.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Aug 28, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a0af9d1e69a41ac9bf7c994b2fa0f4b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 42s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 02s
❌ cifmw-pod-pre-commit FAILURE in 8m 16s
✔️ build-push-container-cifmw-client SUCCESS in 18m 56s
✔️ cifmw-molecule-cifmw_helpers SUCCESS in 2m 18s

@danpawlik danpawlik mentioned this pull request Aug 29, 2025
Merged
evallesp
evallesp reviewed Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@evallesp evallesp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will check properly when moved away from Draft.

@danpawlik danpawlik mentioned this pull request Sep 2, 2025
Merged
@danpawlik danpawlik force-pushed the add-cifmw-helpers branch 2 times, most recently from ea6ac7a to 7716cd1 Compare September 2, 2025 11:15
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul Bot commented Sep 2, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/33d2225e034c47e79ed0fb3988d10818

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 51s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 8m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 45s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 14s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 46s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 27s
✔️ build-push-container-cifmw-client SUCCESS in 16m 31s
✔️ cifmw-molecule-cifmw_helpers SUCCESS in 1m 52s

@danpawlik
Copy link
Copy Markdown
Contributor Author

danpawlik commented Sep 3, 2025

recheck

@danpawlik
Add cifmw_helpers role
8108031 
The new role would provide tasks that would be helpful to drop
nested Ansible execution in the project.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik marked this pull request as ready for review September 8, 2025 06:45
@danpawlik danpawlik requested a review from a team as a code owner September 8, 2025 06:45
@danpawlik danpawlik marked this pull request as draft September 8, 2025 06:46
@danpawlik danpawlik marked this pull request as ready for review September 11, 2025 07:41
@bshewale bshewale merged commit b2d24f2 into openstack-k8s-operators:main Sep 12, 2025
9 of 11 checks passed
@danpawlik danpawlik deleted the add-cifmw-helpers branch September 12, 2025 06:51
danpawlik added a commit to danpawlik/ci-framework that referenced this pull request Sep 17, 2025
@danpawlik
Drop nested ansible execution - e2e-collect-logs
5b164f3 
We want to drop nested Ansible execution where it is possible.
It is wrong, to execute sometimes 4 or 5 time nested Ansible. It
makes debugging difficult, raise more complication and sometimes
variable overwrite is just problematic.

Depends-On: openstack-k8s-operators#3235
Depends-On: openstack-k8s-operators#3287

More: OSPRH-20006

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
evallesp pushed a commit that referenced this pull request Sep 25, 2025
@danpawlik @evallesp
Drop nested ansible execution - e2e-collect-logs
d2e1f18 
We want to drop nested Ansible execution where it is possible.
It is wrong, to execute sometimes 4 or 5 time nested Ansible. It
makes debugging difficult, raise more complication and sometimes
variable overwrite is just problematic.

Depends-On: #3235
Depends-On: #3287

More: OSPRH-20006

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp left review comments

@bshewale bshewale bshewale approved these changes

@amartyasinha amartyasinha amartyasinha approved these changes

@dasm dasm Awaiting requested review from dasm

@brjackma brjackma Awaiting requested review from brjackma

@michburk michburk Awaiting requested review from michburk

Assignees

No one assigned

Labels

Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danpawlik @evallesp @bshewale @amartyasinha