Drop nested ansible execution - e2e-collect-logs#3242
Drop nested ansible execution - e2e-collect-logs#3242evallesp merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5cef1925ccc44fbbeb1d7b72522340e ❌ openstack-k8s-operators-content-provider FAILURE in 11m 38s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9def48b56c4940b9a90647f6b609efb6 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 38s |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
5d94aa5 to
628facc
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
f5debfa to
8507a0d
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
8507a0d to
791c271
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
791c271 to
01a035b
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
01a035b to
88d17b2
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
88d17b2 to
fe65bfe
Compare
|
This change depends on a change that failed to merge. Change #3235 is needed. |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2bd893357b5446f6a67fcc14525e62c7 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 15s |
|
recheck |
|
This change depends on a change that failed to merge. Change #3235 is needed. |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
43d2f5b to
2e397e3
Compare
|
This change depends on a change that failed to merge. Change #3255 is needed. |
|
recheck |
danpawlik
changed the title
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
2e397e3 to
03aea95
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2ecfe44ac24441b6ad87e64c2d27c508 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 42m 30s |
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
03aea95 to
1c64830
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9714735f1a904bfaaa2e7353ba2d17a2 ❌ openstack-k8s-operators-content-provider TIMED_OUT in 33m 31s |
We want to drop nested Ansible execution where it is possible. It is wrong, to execute sometimes 4 or 5 time nested Ansible. It makes debugging difficult, raise more complication and sometimes variable overwrite is just problematic. Depends-On: openstack-k8s-operators#3235 Depends-On: openstack-k8s-operators#3287 More: OSPRH-20006 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
drop-nested-ansible-99-logs
branch
from
1c64830 to
5b164f3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f29dd04738ca466aa62d7c164dbaccd9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 07s |
|
recheck |
There was exception done for run_logs tasks in cifmw_setup role, that calling that role was used in e2e-collect-logs using ansible binary (not ansible-playbook as it is in multiple places). There is no need to run as nested ansible, if it can be called directly. Depends-On: openstack-k8s-operators/ci-framework#3242 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
cescgina
left a comment
cescgina
left a comment
There was a problem hiding this comment.
Logs are collected, change is working fine
danpawlik
requested review from
Valkyrie00,
bshewale,
evallesp,
fmount and
sdatko
5 participants
We want to drop nested Ansible execution where it is possible. It is wrong, to execute sometimes 4 or 5 time nested Ansible. It makes debugging difficult, raise more complication and sometimes variable overwrite is just problematic.
Depends-On: #3235
Depends-On: #3287
More: OSPRH-20006