Drop pre-run and post-run for kuttl_multinode#3231
Conversation
The playbook execution is duplicated and it raises complication in some cases. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cescgina
left a comment
cescgina
left a comment
There was a problem hiding this comment.
+1, these are duplicated from the parent job
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/636b91208f414a708a98f164f71ebafe ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 18s |
|
recheck |
dasm
left a comment
dasm
left a comment
There was a problem hiding this comment.
Yes, the execution is duplicated:
src
Zuul docs describing the behavior:
[...]
In addition to the job’s main playbook, each job may specify one or more pre- and post-playbooks. These are run, in order, before and after (respectively) the main playbook. They may be used to set up and tear down resources needed by the main playbook. When combined with inheritance, they provide powerful tools for job construction. A job only has a single main playbook, and when inheriting from a parent, the child’s main playbook overrides (or replaces) the parent’s. However, the pre- and post-playbooks are appended and prepended in a nesting fashion. So if a parent job and child job both specified pre and post playbooks, the sequence of playbooks run would be:
- parent pre-run playbook
- child pre-run playbook
- child playbook
- child post-run playbook
- parent post-run playbook
…ck-k8s-operators#251 Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231
…ck-k8s-operators#251 Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231
…ck-k8s-operators#251 Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
…ck-k8s-operators#251 Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
Before moving to role, when the 99-logs.yml playbook was executed, the variables was not set to, so it pick default value which is false, so the playbook was executed. Now when it is in `cifmw_setup` role in `run_logs.yml` task file, the condition is possitive, so it is skipped. Add 'zuul_log_collection' var to overwrite other existing vars and trigger gather facts. Depends-On: openstack-k8s-operators/ci-framework#3208 Depends-On: openstack-k8s-operators/ci-framework#3231 Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
4 participants
The playbook execution is duplicated and it raises complication in some cases.