Fix blacklist vpermit_required#1452
Merged
ifrit98 merged 7 commits intoopentensor:new_stagingfrom Jul 26, 2023
Merged
Conversation
- Tweaked description
Contributor
|
Thanks for pointing this out! This is addressed in |
ifrit98
pushed a commit
that referenced
this pull request
Aug 16, 2023
* - Adjusted blacklist argument default to False - Tweaked description * - Fix blacklist vpermit rejecting validators instead of non-validators * - Blacklist vpermit return true without permit, return false with permit * - Added text response to the return value for vpermit
ifrit98
added a commit
that referenced
this pull request
Aug 21, 2023
* remove miniupnpc * remove arg for upnpc * update CONTRIBUTING.md and DEVELOPMENT_WORKFLOW.md (#1475) Co-authored-by: philanthrope <ifrit98@gmail.com> * move styles to style guide * update workflow doc based on comment * update contributing.md delete Architecture section * fix CODE_REVIEW_DOC dev_note link * Update contrib/CONTRIBUTING.md Co-authored-by: philanthrope <ifrit98@gmail.com> * Update contrib/CONTRIBUTING.md Co-authored-by: philanthrope <ifrit98@gmail.com> --------- Co-authored-by: gitphantomman <MinatoLgend0702@outlook.com> Co-authored-by: philanthrope <ifrit98@gmail.com> * add try/except and timeout to version checking with exception handles * Fix blacklist vpermit_required (#1452) * - Adjusted blacklist argument default to False - Tweaked description * - Fix blacklist vpermit rejecting validators instead of non-validators * - Blacklist vpermit return true without permit, return false with permit * - Added text response to the return value for vpermit * add changelog and version * add checks (#1484) * add checks * fix docker img * remove unused multiforward in example * only run check_requirements job when an actual requirement changes * log bittensor pipaddress for version_checking * add perms to checK-compat script * Update contrib/CODE_REVIEW_DOCS.md Co-authored-by: Cameron Fairchild <cameron@opentensor.dev> --------- Co-authored-by: gitphantomman <140101294+gitphantomman@users.noreply.github.com> Co-authored-by: gitphantomman <MinatoLgend0702@outlook.com> Co-authored-by: Inquinim <114695354+Inquinim@users.noreply.github.com> Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying --neuron.blacklist.vpermit_required would REJECT validators that have the vpermit, instead of rejecting those without.
The return statement was also not providing a tuple (bool, str) either like the others.
@shibshib @ifrit98