Merged
Conversation
* update CONTRIBUTING.md and DEVELOPMENT_WORKFLOW.md * Update contrib/DEVELOPMENT_WORKFLOW.md Co-authored-by: philanthrope <ifrit98@gmail.com> * move styles to style guide * update workflow doc based on comment * update contributing.md delete Architecture section * fix CODE_REVIEW_DOC dev_note link * Update contrib/CONTRIBUTING.md Great Co-authored-by: philanthrope <ifrit98@gmail.com> * Update contrib/CONTRIBUTING.md Ditto: Co-authored-by: philanthrope <ifrit98@gmail.com> --------- Co-authored-by: gitphantomman <MinatoLgend0702@outlook.com> Co-authored-by: philanthrope <ifrit98@gmail.com>
* - Adjusted blacklist argument default to False - Tweaked description * - Fix blacklist vpermit rejecting validators instead of non-validators * - Blacklist vpermit return true without permit, return false with permit * - Added text response to the return value for vpermit
* add checks * fix docker img * fix docker img2
ifrit98
requested review from
Eugene-hu,
camfairchild,
eduardogr,
p-ferreira and
shibshib
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
eduardogr
reviewed
Aug 18, 2023
Contributor
eduardogr
left a comment
eduardogr
left a comment
There was a problem hiding this comment.
after solving comments, all good from my side.
Very nice!
camfairchild
approved these changes
Aug 18, 2023
Contributor
camfairchild
left a comment
camfairchild
left a comment
There was a problem hiding this comment.
Looks, good. Just one nit with the wording
Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
p-ferreira
approved these changes
Aug 21, 2023
Eugene-hu
approved these changes
Aug 21, 2023
| + (10 * int(version_split[1])) | ||
| + (1 * int(version_split[2])) | ||
| ) | ||
| def version_checking(timeout: int = 15): |
Contributor
There was a problem hiding this comment.
Really like this change; we should be more careful whenever we call external apis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor release to 5.3.4