add cicleci check for requirements python version support#1480
Closed
ifrit98 wants to merge 3 commits intonew_stagingfrom
Closed
add cicleci check for requirements python version support#1480ifrit98 wants to merge 3 commits intonew_stagingfrom
ifrit98 wants to merge 3 commits intonew_stagingfrom
Conversation
eduardogr
reviewed
Aug 10, 2023
Comment on lines
+53
to
+55
| - run: | ||
| name: Make script executable | ||
| command: chmod +x ./scripts/check_compatibility.sh |
Contributor
There was a problem hiding this comment.
i think it is enough adding the permissions in the repository itself, can you try it?
If that is the case we can avoid this step
Contributor
Author
There was a problem hiding this comment.
Thanks Edu! Ended up resolving these in: #1483
eduardogr
reviewed
Aug 10, 2023
eduardogr
reviewed
Aug 10, 2023
eduardogr
reviewed
Aug 10, 2023
Contributor
Author
|
Migrating to: #1483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does 2 thins: