fix: increase stacklevel in LoggingMachine log calls#2476
Merged
ibraheem-abe merged 13 commits intoopentensor:stagingfrom Nov 26, 2024
Merged
fix: increase stacklevel in LoggingMachine log calls#2476ibraheem-abe merged 13 commits intoopentensor:stagingfrom
ibraheem-abe merged 13 commits intoopentensor:stagingfrom
Conversation
Collaborator
|
Thank you for this contribution! |
Contributor
Author
|
ref: python/cpython#97941 |
basfroman
requested changes
Nov 25, 2024
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
plz fix ruff formatter issue
basfroman
requested changes
Nov 25, 2024
basfroman
requested changes
Nov 26, 2024
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
Pls accept changes and we can move forward with approval
Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com>
Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com>
basfroman
requested changes
Nov 26, 2024
basfroman
approved these changes
Nov 26, 2024
thewhaleking
approved these changes
Nov 26, 2024
ibraheem-abe
approved these changes
Nov 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #2449
Description of the Change
"loggingmachine.py" is printed in logs because LoggingMachine does not unstack it's internal calls to wrapped logger
Alternate Designs
Adding LoggerAdapter
Possible Drawbacks
None
Verification Process
Ran unittests.
Checked logs are formatted correctly.
Release Notes