Warn on Move vs. Transfer

[Jackalgirl]

It's easy to get mixed up as to what's going to happen with btcli st move vs. btcli st transfer, since the words are essentially synonyms. I'd recommend that when someone uses one or the other, you provide a Y/N checkpoint such as:

For "move"
This transaction will move stake to another hotkey while keeping the same coldkey ownership. Do you wish to continue? (Y/n)

For "transfer"
This transaction will transfer ownership from one coldkey to another, in subnets that have enabled it. You should ensure that the destination coldkey is not a validator hotkey before continuing. Do you wish to continue? (Y/n)

(Or something like.) I think it's important, especially in the case of "transfer", to give people a chance to recognize if they're doing something that's going to require them to depend on someone else to fix.

[RD4Fun]

there is another issue with transfer
if the destination CK is in use as a HK should the transfer really occur?

[Jackalgirl]

This is especially important if the destination coldkey is already in use as a hotkey, if that can be divined, which would warrant a separate warning:

This transaction will transfer ownership from the current coldkey to a new coldkey that is currently in use as a hotkey. Are you sure you want to do this? (Y/n)

[Jackalgirl]

Another option would be to change the extrinsic/command to "transfer-ownership", forcing people not only to type out the whole thing, but making it clear in the command itself that what you're doing is transferring ownership.

(If the extrinsic name were changed from transferStake to transferStakeOwnership that might also make it more clear at the blockchain level that this is what's happening if/when you invoke that extrinsic, and might make it easier for front-end/wallet app developers too)

[prop-opentensor]

there is another issue with transfer if the destination CK is in use as a HK should the transfer really occur?

Ideally, a w transfer would similarly warn if the key is registered as a hotkey. It happens almost as frequently as accidental stake transfers.

[thewhaleking]

Will be resolved by #672