Skip to content

Randomise rpc request ID#131

Merged
thewhaleking merged 2 commits intostagingfrom
fix/thewhaleking/rpc_request
Oct 1, 2024
Merged

Randomise rpc request ID#131
thewhaleking merged 2 commits intostagingfrom
fix/thewhaleking/rpc_request

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Sep 27, 2024

Randomise the 'rpc_request' ID so as to avoid any potential naming conflicts when pulling from the websocket dict. This is an edge case.

@thewhaleking thewhaleking changed the base branch from main to staging October 1, 2024 17:25
@thewhaleking thewhaleking marked this pull request as ready for review October 1, 2024 17:25
@thewhaleking thewhaleking changed the title Fix/thewhaleking/rpc request Randomise rpc request ID Oct 1, 2024
@thewhaleking thewhaleking merged commit edd3764 into staging Oct 1, 2024
@thewhaleking thewhaleking deleted the fix/thewhaleking/rpc_request branch October 1, 2024 17:26
@ibraheem-abe ibraheem-abe mentioned this pull request Oct 2, 2024
thewhaleking added a commit that referenced this pull request Oct 10, 2024
thewhaleking added a commit that referenced this pull request Oct 10, 2024
…prev delegate fetching (#175)

* Fixes issue from #131 where "rpc_request" was not changed to `payload_id` in the error handler.

* Correctly use default empty values to avoid None issues.

* Previous delegates fetching fix for non-archive nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant