Fixes for rpc request error handler, root list default empty values, prev delegate fetching#175
Merged
thewhaleking merged 3 commits intostagingfrom Oct 10, 2024
Conversation
…_id` in the error handler.
ibraheem-abe
approved these changes
Oct 10, 2024
basfroman
approved these changes
Oct 10, 2024
thewhaleking
changed the title
thewhaleking
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #131 we changed the request id of "rpc_request" to a randomised ID. Unfortunately, I neglected to update the error handler to reflect this change.
root listwould fail because of None values in an ugly way. Use default empty values (such as[]) for returns now.Fixes
root list-delegatesrunning on non-archive nodes (such as local chain) by attempting to grab at a -1200 block offset first, then -200, then defaulting to None if previous delegates cannot be fetched.