Hotkey draining issues

[gztensor]

1. Childkey take gets added to PendingdHotkeyEmission in accumulate_hotkey_emission and then is distributed among nominators in drain_hotkey_emission.
2. Miner emission is also subject to distribution to nominators in drain_hotkey_emission because it is added to PendingdHotkeyEmission.
3. When childkey take is calculated in accumulate_hotkey_emission, it is calculated off the total childkey pending emission, even if some portion of it comes not from parent, but from nominators.

[gztensor]

Branch: hotfix/childkey-emission-distibution

[gztensor]

PR: #950

[mogmachine]

So does this no longer share child key take with nominators? This is a great shame, it is a natural wish that a validator would want to share child key take .. it is usually added to prevent a straight 'copying' scenario and implement a natural feee/penalty for the parent but also an overall gain for those delegating to the child.

This way it just becomes a selfish cash grab for the child whilst not allowing them to easily distribute the take amongst all nominators which is fairest.

[gztensor]

That's the original design behind child key take: Child key takes the % of the emission targeted for parent's portion of the stake (not nominators) and distributes the rest, it works just like delegate take.

Before this fix the childkey take was distributed just like the rest of emission, which makes the take feature pointless.

After this fix:

• If childkey has stake from parent and nominators, it's entitled for emission.
• The childkey take only applies to the portion of emission that childkey gets because of the parent stake

Example:

• Childkey has 1000 TAO from parent and 1000 TAO from nominators
• Validator emission for childkey is 10 TAO
• Childkey take is 10% (in this example for simplicity)
• Childkey take is 0.5 TAO, that is not distributed
• 4.5 TAO goes to parent
• 5 TAO goes to nominators

@mogmachine