Skip to content

Fix/childkey emission distribution#950

Merged
sam0x17 merged 4 commits intodevnet-readyfrom
fix/childkey-emission-distibution
Nov 15, 2024
Merged

Fix/childkey emission distribution#950
sam0x17 merged 4 commits intodevnet-readyfrom
fix/childkey-emission-distibution

Conversation

@gztensor
Copy link
Contributor

@gztensor gztensor commented Nov 8, 2024

Description

Fixes hotkey draining issues:

  1. Miner emission should not be distributed to nominators
  2. Childkey take should not be distributed to nominators

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor requested a review from unconst as a code owner November 8, 2024 17:28
@gztensor gztensor changed the base branch from main to devnet-ready November 8, 2024 17:29
@gztensor gztensor changed the title Fix/childkey emission distibution Fix/childkey emission distribution Nov 8, 2024
sam0x17
sam0x17 previously approved these changes Nov 8, 2024
camfairchild
camfairchild previously approved these changes Nov 12, 2024
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a nit

@gztensor gztensor dismissed stale reviews from camfairchild and sam0x17 via 0b49118 November 13, 2024 00:02
camfairchild
camfairchild previously approved these changes Nov 13, 2024
@sam0x17 sam0x17 merged commit 2b80315 into devnet-ready Nov 15, 2024
@gztensor gztensor mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hotkey draining issues

3 participants