Skip to content

Feat/aggregate stakes more extrinsics#1549

Merged
shamil-gadelshin merged 4 commits intoaggregate-stakesfrom
feat/aggregate-stakes-more-extrinsics
Apr 23, 2025
Merged

Feat/aggregate stakes more extrinsics#1549
shamil-gadelshin merged 4 commits intoaggregate-stakesfrom
feat/aggregate-stakes-more-extrinsics

Conversation

@shamil-gadelshin
Copy link
Collaborator

Description

This PR adds additional staking extrinsics:

  • unstake_all_aggregate
  • unstake_all_alpha_aggregate

This is a subtask for #1525

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): add benchmarks for existing code

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review April 17, 2025 16:38
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 17, 2025
@sam0x17 sam0x17 requested a review from a team April 17, 2025 16:53
_ => sp_std::cmp::Ordering::Equal, // unreachable
});

unstake_all.sort_by(|a, b| match (a, b) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment to #1525

@shamil-gadelshin shamil-gadelshin merged commit e8c42fe into aggregate-stakes Apr 23, 2025
This was referenced Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants