Hotfix/no registration no emission#474
Merged
distributedstatemachine merged 7 commits intomainfrom May 27, 2024
Merged
Conversation
This was referenced May 25, 2024
orriin
approved these changes
May 27, 2024
camfairchild
suggested changes
May 27, 2024
Contributor
camfairchild
left a comment
camfairchild
left a comment
There was a problem hiding this comment.
Looks good other than an extra test
camfairchild
approved these changes
May 27, 2024
13 tasks
keithtensor
reviewed
Jun 13, 2024
| ); | ||
|
|
||
| // drain the emission tuples for the subnet with registration on | ||
| SubtensorModule::drain_emission(next_block as u64); |
Contributor
There was a problem hiding this comment.
This is casting a function pointer to a u64, did you really mean to call next_block() here?
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR burns emissions for subnets that has registration turned off
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.