Skip to content

[Fix] Run epoch no emission#525

Closed
camfairchild wants to merge 2 commits intomainfrom
fix/run-epoch-no-emission
Closed

[Fix] Run epoch no emission#525
camfairchild wants to merge 2 commits intomainfrom
fix/run-epoch-no-emission

Conversation

@camfairchild
Copy link
Contributor

Description

When a subnet has a disabled registration during the epoch, we skip giving it emission. This was implemented in #474 but accidentally also skipped the epoch, making the incentive not update as we would expect. This fix emits 0 emission instead of exiting the epoch early.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@distributedstatemachine distributedstatemachine mentioned this pull request Jul 1, 2024
13 tasks
@distributedstatemachine
Copy link
Collaborator

closing in favour of #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants