Skip to content

Feat/check metadata hash extension#642

Closed
camfairchild wants to merge 57 commits intodevnet-readyfrom
feat/check-metadata-hash-extension
Closed

Feat/check metadata hash extension#642
camfairchild wants to merge 57 commits intodevnet-readyfrom
feat/check-metadata-hash-extension

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Jul 16, 2024

Description

Devnet Companion for #637

Upgrades to polkadot-sdk v1.10.0-rc2 v1.10.0-rc3 which supports frame_metadata_hash_extension::CheckMetadataHash, required for Zondax's generic-substrate Ledger app.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): requires new build flags for production (to generate metadata hash for wasm)

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

TODO:

  • Test integration with PolkadotJS, other wallets, etc.

@camfairchild camfairchild requested a review from sam0x17 July 18, 2024 15:51
sam0x17
sam0x17 previously approved these changes Jul 18, 2024
@sam0x17
Copy link
Contributor

sam0x17 commented Jul 18, 2024

note: added a blank commit to bump CI since this PR had that issue where it was originally accidentally into main and needs to re-run the label logic but changing bases doesn't trigger that. Let me see if I can make a PR to fix that 🤔

@camfairchild
Copy link
Contributor Author

Closed in favour of #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants