Restructire the POD of macros (ui)#1266
Conversation
macros/ui/PGchoicemacros.pl
Outdated
| =over | ||
|
|
||
| =item [DEPRECATED] qa() | ||
| =head2 qa() [DEPRECATED] |
There was a problem hiding this comment.
If we're staying with the convention that function and method names do not have a () at the end, this should be updated and many other places in the file.
|
Here's my take on all of these, including the original #1244. They don't have to make the POD perfect, or perfectly uniform in style. As long as these changes are improvements, we could merge them. |
|
As I started working on this-- big rabbit hole. Agreed, this improves. Also, thanks for splitting up. I should have done that from the beginning. |
|
Wait, did you mean to merge the "math" POD changes into the ui branch? I just merged your PR without looking closely. (Which I may continue doing since I'm thinking of these as your PRs.) |
|
Or maybe now I'm seeing this is my doing. Did I open this one with both the math and ui changes? Sorry if I did! |
|
Looks like I screwed this up. My bad. Wondering how to fix. |
|
Looks like I suggested the PR to merge into the UI branch. Uggh. |
Alex-Jordan
force-pushed
the
restructure-pod-macros-ui
branch
from
ccf4a9b to
bf5a1ec
Compare
Remove () from function names.
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
I am going to add a pull request that does all of these things. Once that is merged, then I approve this pull request.
Fix issues noted in my review of openwebwork#1266.
Fix issues noted in my review of openwebwork#1266.
drgrice1
force-pushed
the
restructure-pod-macros-ui
branch
from
0eb868b to
435674d
Compare
Fix issues noted in my review of openwebwork#1266.
drgrice1
force-pushed
the
restructure-pod-macros-ui
branch
from
435674d to
79a3fe9
Compare
3 participants
This is part of an alternative to #1244, breaking it down into smaller PRs for review.