Restructure the POD of macros#1244
Conversation
ea9d812 to
52d9c92
Compare
21d6afc to
daac4b1
Compare
Alex-Jordan
left a comment
There was a problem hiding this comment.
I'm trusting that this is only POD edits as advertised. I'm not actually reading over all the changes.
daac4b1 to
39ce4ca
Compare
drgrice1
left a comment
There was a problem hiding this comment.
There are several changes that are needed.
Make sure that if a file has =encoding utf8 that that is NOT removed. Also, note that there is also a unicode character used in macros/parsers/parserLinearInequality.pl, and so that file should have =encoding utf8 added to the beginning. Please add that.
Go through all files that you added comments at the beginning regarding deprecation and such, and remove those comments. We could start a GitHub discussion about that, but it should not be added to the code.
For consistency the POD of macros have been updated so that there is a `=HEAD1 NAME` with the following structure: ``` macroName.pl - short description. ```
48fe516 to
b7c2dae
Compare
|
By the way, one thing I noticed while looking at this pull request is that there is a very common misspelling in the POD of PG. The word
It wouldn't hurt to fix that. |
|
Changed the spelling of SYNOPSIS and fixed a number of other POD errors in modules seen using |
drgrice1
left a comment
There was a problem hiding this comment.
I think that you should be more careful with the choice of header levels. Those have meaning. You initially had an objective of putting methods and functions at the head2 level. That led to some bad things. Look over the changes carefully and revert things that shouldn't have been done.
Perhaps consider breaking this massive pull request up into a few files at a time also.
|
I think I'll split this up into smaller PRs and now that we have openwebwork/webwork#2759, I'll revert the changes from |
Some other formatting fixes.
0cd1971 to
abbefab
Compare
|
@drgrice1 I split off all of the perl modules in the I tried to be more careful with the levels of the Note: still a lot to be done. Some macros are bare of any documentation, but not sure those are worth putting effort into. If this is still too large, I can split into two parts. |
drgrice1
left a comment
There was a problem hiding this comment.
Clearly this pull request would not be so big if there were not so many changes made that shouldn't have been made to begin with.
|
@drgrice1 fixed all of your comments. I'll start a GitHub discussion with a list of many of the comments I put at the top of the macros. |
For consistency the POD of macros have been updated so that there is a
=head1 NAMEwith the following structure:Also, any method or function names will have the form:
This is helpful in conjunction with openwebwork/webwork2#2733 to extract information from the macro files.