Restructire the POD of macros (graph)#1269
Merged
drgrice1 merged 3 commits intoopenwebwork:PG-2.20from Jul 20, 2025
Merged
Conversation
pstaabp
approved these changes
Jul 14, 2025
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jul 17, 2025
drgrice1
reviewed
Jul 17, 2025
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
There are a few places where the added name section has an sentence after the dash added that is not capitalized, and the PGgraphmacros.pl has inconsistent "Usage" handling.
I will add a pull request to this branch that fixes these things, and then this pull request looks like it is in order.
macros/graph/plots.pl
Outdated
| ); | ||
|
|
||
| If needed, the C<< $plot->add_dataset >> method returns the L<Data|/"DATA OBJECT"> object | ||
| If needed, the C<< $plot->add_dataset >> method returns the L<DATASETS> object |
Member
There was a problem hiding this comment.
In order for this to work in webwork2's POD viewer this should be
Suggested change
| If needed, the C<< $plot->add_dataset >> method returns the L<DATASETS> object | |
| If needed, the C<< $plot->add_dataset >> method returns the L<Data|Data.pm/"DATA OBJECT"> object |
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jul 17, 2025
…anup Suggestions from my review of openwebwork#1269.
drgrice1
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an alternative to #1244, breaking it down into smaller PRs for review.