Fix pointer focus for the center of a circle.#676
Merged
pstaabp merged 1 commit intoopenwebwork:PG-2.17from May 20, 2022
Merged
Fix pointer focus for the center of a circle.#676pstaabp merged 1 commit intoopenwebwork:PG-2.17from
pstaabp merged 1 commit intoopenwebwork:PG-2.17from
Conversation
Curently the center point of a circle can not be focused by clicking on it with the mouse. This is because the jsxgraph circle hasPoint method only returns true if the circle itself contains the given point, but not if the center point contains the given point. So redefine the hasPoint method for a circle to fix that.
Member
Author
|
To test this you can use the attached problem. In that problem, graph a circle and then click on the point on the circle itself. Then click on the center point again. Without this pull request, focus will not go back to the center point when you click on it. With this pull request it will. Note that with or without this pull request you can get focus to the center point using tab or shift-tab (whichever is needed, depending on where focus is). |
pstaabp
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curently the center point of a circle can not be focused by clicking on it with the mouse. This is because the jsxgraph circle hasPoint method only returns true if the circle itself contains the given point, but not if the center point contains the given point. So redefine the hasPoint method for a circle to fix that.