Fix the prevention of creating degenerate objects with keyboard contols.#693
Merged
pstaabp merged 1 commit intoopenwebwork:PG-2.17from Jul 6, 2022
Merged
Conversation
…ols. When graphing a parabola (via any of the tools that do so) or a cubic it is possible to create degenerate objects. The code that is supposed to prevent that wasn't quite working right. The jsxgraph board object needs to be updated after setting the position of a point programatically. To test this graph any of those objects and then move one of the defining points of the object around with the keyboard. For example, graph a three point quadratic and try to move one point onto the same vertical line as another point. That should not be possible.
pstaabp
approved these changes
Jun 17, 2022
Member
|
See #676 for a demo problem. |
Member
Author
|
You can test this with https://github.com/openwebwork/pg/files/8729067/Demo.pg.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When graphing a parabola (via any of the tools that do so) or a cubic it is possible to create degenerate objects. The code that is supposed to prevent that wasn't quite working right. The jsxgraph board object needs to be updated after setting the position of a point programatically.
To test this graph any of those objects and then move one of the defining points of the object around with the keyboard. For example, graph a three point quadratic and try to move one point onto the same vertical line as another point. That should not be possible.