Restore the functionality of the LiveGraphics3D.pl macro.#732
Restore the functionality of the LiveGraphics3D.pl macro.#732pstaabp merged 1 commit intoopenwebwork:developfrom
Conversation
7312c90 to
2ba7c4f
Compare
|
By the way, here is a list of all of the OPL problems that use the LiveGraphics3D.pl macro. |
|
I think it should be a hotfix, there are probably plenty of instructors in the same situation as I was: I am reusing all my homework set from last year in my Calc 3 class. After publishing the last one, emails started coming in that two of the problems do not work. I was able to install the necessary javascript files on our server, and it indeed seems to work fine, did not have any further complaints since Wednesday. I came here last night to open an issue on it only to discover that the discussion is already going on :). |
It turns out @taniwallach was correct in that the javascript conversion method does work. See the discussion in openwebwork#728. There is still some more work that is needed here (cleanup really). The se_javascript_for_live3d option needs to be removed, and that needs to be always used. Setting that option to 0 will fail in any case. This pull request makes these problems work at least.
2ba7c4f to
fe3a433
Compare
|
Actually, here is a more complete list of OPL problems that use the LiveGraphics3D.pl macro. This adds problems that use that macro indirectly via some FortLewis macros in the OPL. |
somiaj
left a comment
There was a problem hiding this comment.
Tested a few of the surface plots and they all seem to be working with this. Probably worth a hotfix, as this makes a bunch of currently broken problems functional again, and shouldn't mess with anything except problems that use this library.
A side comment is an improvement would be to draw the coordinate axes. There are numbers in each axis direction on the surface plots, but no axes drawn, which makes reading the graph a bit awkward (though this might be more than the fix of just getting functionality back and I don't recall what the original java applet did with coordinate axes).
|
This pull request restored the functionality of the macro to what it was before. It does not attempt to make improvements on it. |
|
In fact what you are asking seems to be something the problems need to implement. Some of them do. I see axes on some problems. |
|
Ahh okay, so the feature is there, it just isn't being used. The problems I looked at weren't using axes, but I only looked at some of the list you provided. |
|
I don't really know much about this. All of the OPL problems are listed in the previously attached file. Some use a different technique that seems to yield nicer imagery. |
|
I also would like this to also be a hotfix. |
pstaabp
left a comment
There was a problem hiding this comment.
Looks good and hot-fix seems right for this.
It turns out @taniwallach was correct in that the javascript conversion method does work. See the discussion in #728.
Note that the usage of the use_javascript_for_live3d option has been removed. That is just how it works. Anything else will fail anyway.
This perhaps should be a hotfix? Vote please.