Skip to content

Restore the functionality of the LiveGraphics3D.pl macro.#732

Merged
pstaabp merged 1 commit intoopenwebwork:developfrom
drgrice1:restore-live-graphics-3d
Oct 5, 2022
Merged

Restore the functionality of the LiveGraphics3D.pl macro.#732
pstaabp merged 1 commit intoopenwebwork:developfrom
drgrice1:restore-live-graphics-3d

Conversation

@drgrice1
Copy link
Member

@drgrice1 drgrice1 commented Sep 30, 2022

It turns out @taniwallach was correct in that the javascript conversion method does work. See the discussion in #728.

Note that the usage of the use_javascript_for_live3d option has been removed. That is just how it works. Anything else will fail anyway.

This perhaps should be a hotfix? Vote please.

@drgrice1 drgrice1 force-pushed the restore-live-graphics-3d branch from 7312c90 to 2ba7c4f Compare September 30, 2022 13:55
@drgrice1
Copy link
Member Author

By the way, here is a list of all of the OPL problems that use the LiveGraphics3D.pl macro.
live-graphics-3d-problems.txt

@lahvak
Copy link

lahvak commented Sep 30, 2022

I think it should be a hotfix, there are probably plenty of instructors in the same situation as I was: I am reusing all my homework set from last year in my Calc 3 class. After publishing the last one, emails started coming in that two of the problems do not work. I was able to install the necessary javascript files on our server, and it indeed seems to work fine, did not have any further complaints since Wednesday. I came here last night to open an issue on it only to discover that the discussion is already going on :).

It turns out @taniwallach was correct in that the javascript conversion
method does work.  See the discussion in openwebwork#728.

There is still some more work that is needed here (cleanup really).  The
se_javascript_for_live3d option needs to be removed, and that needs to
be always used.  Setting that option to 0 will fail in any case.  This
pull request makes these problems work at least.
@drgrice1 drgrice1 force-pushed the restore-live-graphics-3d branch from 2ba7c4f to fe3a433 Compare September 30, 2022 14:19
@drgrice1
Copy link
Member Author

Actually, here is a more complete list of OPL problems that use the LiveGraphics3D.pl macro. This adds problems that use that macro indirectly via some FortLewis macros in the OPL.
live-graphics-3d-problems.txt

Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a few of the surface plots and they all seem to be working with this. Probably worth a hotfix, as this makes a bunch of currently broken problems functional again, and shouldn't mess with anything except problems that use this library.

A side comment is an improvement would be to draw the coordinate axes. There are numbers in each axis direction on the surface plots, but no axes drawn, which makes reading the graph a bit awkward (though this might be more than the fix of just getting functionality back and I don't recall what the original java applet did with coordinate axes).

@drgrice1
Copy link
Member Author

This pull request restored the functionality of the macro to what it was before. It does not attempt to make improvements on it.

@drgrice1
Copy link
Member Author

In fact what you are asking seems to be something the problems need to implement. Some of them do. I see axes on some problems.

@somiaj
Copy link
Contributor

somiaj commented Sep 30, 2022

Ahh okay, so the feature is there, it just isn't being used. The problems I looked at weren't using axes, but I only looked at some of the list you provided.

@drgrice1
Copy link
Member Author

I don't really know much about this. All of the OPL problems are listed in the previously attached file. Some use a different technique that seems to yield nicer imagery.

@taniwallach
Copy link
Member

I also would like this to also be a hotfix.

Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and hot-fix seems right for this.

@pstaabp pstaabp merged commit 1524982 into openwebwork:develop Oct 5, 2022
@drgrice1 drgrice1 deleted the restore-live-graphics-3d branch October 5, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants