Restore the functionality of the LiveGraphics3D.pl macro. (hotfix)#733
Merged
pstaabp merged 1 commit intoopenwebwork:mainfrom Oct 5, 2022
Merged
Conversation
It turns out @taniwallach was correct in that the javascript conversion method does work. See the discussion in openwebwork#728. There is still some more work that is needed here (cleanup really). The se_javascript_for_live3d option needs to be removed, and that needs to be always used. Setting that option to 0 will fail in any case. This pull request makes these problems work at least.
Member
|
This was approved in #732 for develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out @taniwallach was correct in that the javascript conversion method does work. See the discussion in #728.
There is still some more work that is needed here (cleanup really). The se_javascript_for_live3d option needs to be removed, and that needs to be always used. Setting that option to 0 will fail in any case. This pull request makes these problems work at least.
This is the hotfix for main as requested.