[change] Handle skipped tests in SeleniumTestMixin#570
[change] Handle skipped tests in SeleniumTestMixin#570nemesifier merged 1 commit intoopenwisp:masterfrom
Conversation
📝 WalkthroughWalkthroughAdds skip propagation to the SeleniumTestMixin retry logic so that if a retry attempt yields a skipped test, each skip reason is forwarded to the original test result via Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nemesifier
left a comment
There was a problem hiding this comment.
Thanks @asmodehn, LGTM.
Let's avoid unnecessary blank lines because it's making my reviewer life harder, I'll commit these suggestions unless this stupid github UI gives me error again.

Checklist
Reference to Existing Issue
Closes #569 .
Description of Changes
Here we check if the test has been skipped, to correctly report it as skipped.
It s a quick patch that worked on my setup. Feel free to adjust.
Related concerns:
We might want to double check the behavior of an
@expectedFailuretest marker...